Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Java 11 #64

Closed
marek-parfianowicz opened this issue Dec 17, 2019 · 8 comments
Closed

Support Java 11 #64

marek-parfianowicz opened this issue Dec 17, 2019 · 8 comments
Assignees
Labels
Milestone

Comments

@marek-parfianowicz
Copy link
Member

Java 11 is planned for September, 2018. Ensure OpenClover is compatible.

Main language changes: * Local-Variable Syntax for Lambda Parameters (JEP 323)

Tasks:

(similar to those in Java 9 and 10)

see https://dzone.com/articles/an-early-look-at-features-targeted-for-java-11 for example.

@marek-parfianowicz
Copy link
Member Author

Original report: https://bitbucket.org/openclover/clover/issues/64

@marek-parfianowicz marek-parfianowicz added this to the 4.8.0 milestone Dec 17, 2019
@freshcodemonger
Copy link

If no Java 11 features are used, could openclover function with java 11 by just supporting the version in the following file:

https://bitbucket.org/openclover/clover/src/default/clover-core/src/main/java/com/atlassian/clover/cfg/instr/java/JavaInstrumentationConfig.java

The code I instrument doesn’t use any Java features higher then 8 it just happens to compile using JDK 11. If it is a quick change to support that maybe a small stepping stone in getting to JDK 11?

@marek-parfianowicz
Copy link
Member Author

marek-parfianowicz commented Jan 23, 2020 via email

@freshcodemonger
Copy link

I am using the gradle open clover plugin. So your suggestion is to launch gradle with jdk11 but then in the clover configuration switch to compiler.executable of jdk8?

@marek-parfianowicz
Copy link
Member Author

I'm not sure if the gradle-clover-plugin has this option, but clover-for-ant has the 'source' property (see http://openclover.org/doc/manual/latest/ant--clover-setup.html). Similarly, clover-maven-plugin has 'jdk' property (see http://openclover.org/doc/maven/latest/setup-mojo.html#jdk).

@freshcodemonger
Copy link

Thanks. I put some more time into this and I can now get the clover reports to work. sourceCompatiblity worked. javaCompile.sourceCompatiblity did not - probably a problem with the gradle plugin.

@marek-parfianowicz
Copy link
Member Author

Already implemented in releases 4.5.0-4.5.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants