Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[sampling] fix inhomogeneous sampling and avoid recursion error #556
Gives a putative solution for recursion limit errors when using
Fixes bugs related to inhomogeneous sampling. Turns out the reprojection strategy was overly complicated and did not work well since it spans very little of the space. As a consequence inhomogeneous sampling often returned identical samples (fixes #558). Using
The sampling problem now stores the nullspace rather than the entire projection (N * N.T) which reduces the memory footprint since it uses memory in the order of
Log some minor issues the sampler resolves automatically as info for better debugging.
@@ Coverage Diff @@ ## devel #556 +/- ## ========================================= + Coverage 71.11% 71.31% +0.2% ========================================= Files 65 65 Lines 8689 8715 +26 Branches 1477 1475 -2 ========================================= + Hits 6179 6215 +36 + Misses 2240 2234 -6 + Partials 270 266 -4