New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sampling] Fix a reprojection bug #564

Merged
merged 3 commits into from Aug 5, 2017

Conversation

Projects
None yet
3 participants
@cdiener
Member

cdiener commented Aug 1, 2017

In rare cases the reprojection will yield bounds violations. If that occurs along with an infeasible sampling center the sampler will fail. This PR now guarantees that sampler._reproject always returns a feasible point and will not attempt to reproject already feasible points either (like it did before).

@cdiener cdiener added the ready label Aug 1, 2017

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Aug 1, 2017

Codecov Report

Merging #564 into devel will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel     #564      +/-   ##
==========================================
+ Coverage   71.31%   71.36%   +0.05%     
==========================================
  Files          65       65              
  Lines        8715     8731      +16     
  Branches     1475     1477       +2     
==========================================
+ Hits         6215     6231      +16     
  Misses       2234     2234              
  Partials      266      266
Impacted Files Coverage Δ
cobra/flux_analysis/sampling.py 91.59% <100%> (+0.33%) ⬆️
cobra/test/test_flux_analysis.py 85.98% <100%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b96d1e7...7db2f9e. Read the comment docs.

codecov-io commented Aug 1, 2017

Codecov Report

Merging #564 into devel will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel     #564      +/-   ##
==========================================
+ Coverage   71.31%   71.36%   +0.05%     
==========================================
  Files          65       65              
  Lines        8715     8731      +16     
  Branches     1475     1477       +2     
==========================================
+ Hits         6215     6231      +16     
  Misses       2234     2234              
  Partials      266      266
Impacted Files Coverage Δ
cobra/flux_analysis/sampling.py 91.59% <100%> (+0.33%) ⬆️
cobra/test/test_flux_analysis.py 85.98% <100%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b96d1e7...7db2f9e. Read the comment docs.

cdiener added some commits Aug 1, 2017

@hredestig

👍

@hredestig hredestig merged commit 7629980 into opencobra:devel Aug 5, 2017

4 checks passed

codecov/patch 100% of diff hit (target 71.31%)
Details
codecov/project 71.36% (+0.05%) compared to b96d1e7
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hredestig hredestig removed the ready label Aug 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment