Quick fix for summary methods with exchange objective

[pstjohn]

Previously model.optimize could get passed a list of reactions in which one reaction was duplicated. This PR fixes #593 by making sure duplicate reactions are dropped prior to calling model.optimize.

[cdiener]

Good catch! Do you have an idea why any of those can return duplicate reactions? Should not be possible based on my understanding...

[pstjohn]

Yeah, it only happens when the objective reactions also appear in the boundary reactions 😄

[cdiener]

Ah, of course :) thanks

[Midnighter]

Could you add a test case for this, too, please. I think it's a good idea to start collecting these edge cases so we're future proof.

[codecov-io]

Codecov Report

Merging #595 into devel will increase coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##            devel     #595      +/-   ##
==========================================
+ Coverage   71.41%   71.46%   +0.05%     
==========================================
  Files          65       65              
  Lines        8784     8787       +3     
  Branches     1491     1491              
==========================================
+ Hits         6273     6280       +7     
+ Misses       2242     2239       -3     
+ Partials      269      268       -1

Impacted Files	Coverage Δ
cobra/test/test_flux_analysis.py	86.41% <100%> (+0.08%)	⬆️
cobra/flux_analysis/summary.py	80.64% <100%> (ø)	⬆️
cobra/flux_analysis/sampling.py	91.59% <0%> (+1.68%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 996ba7b...99aec19. Read the comment docs.

[cdiener]

Looks good to me.