Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds basic python support #238

Merged
merged 5 commits into from Oct 14, 2019

Conversation

@DuaneOBrien
Copy link
Contributor

commented Oct 5, 2019

This is a first pass that should handle basic requirements.txt files for the purpose of providing some python support as outlined in #34

  • updates front end components to add Python to the list of supported files
  • updates Upload component snapshots for testing
  • creates requirements dependency manager and adds it to the list of managers
  • adds Python to the supported languageTypes
  • updates dependencies tests and associated test file

I'm unclear how the projects.json file is generated, but I tested locally by adding the following to projects.json at line 3012:

{ "type": "requirements", "name": "babel" }

Screenshot below

Screen Shot 2019-10-04 at 9 24 00 PM

Marking this as a draft PR until we get a chance to discuss.

DuaneOBrien added 4 commits Oct 5, 2019
Updating my fork
@now

This comment has been minimized.

Copy link

commented Oct 5, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@DuaneOBrien DuaneOBrien changed the title Adds basic python support (Issue #34) Adds basic python support Oct 5, 2019
@codecov-io

This comment has been minimized.

Copy link

commented Oct 5, 2019

Codecov Report

Merging #238 into master will increase coverage by 3.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
+ Coverage   49.13%   52.22%   +3.08%     
==========================================
  Files          14       15       +1     
  Lines         232      247      +15     
  Branches       41       45       +4     
==========================================
+ Hits          114      129      +15     
  Misses         96       96              
  Partials       22       22
Impacted Files Coverage Δ
src/lib/dependencies/data.js 63.33% <ø> (ø) ⬆️
src/lib/dependencies/supported-files.js 100% <ø> (ø) ⬆️
src/lib/dependencies/dependency-managers.js 100% <ø> (ø) ⬆️
src/lib/dependencies/pypi.js 100% <100%> (ø)
test/files/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef66660...af144be. Read the comment docs.

@znarf

This comment has been minimized.

Copy link
Member

commented Oct 5, 2019

Looks great! Do you have an example GitHub profile (user or organization) that could be used to highlight that Python support is working?

@DuaneOBrien

This comment has been minimized.

Copy link
Contributor Author

commented Oct 5, 2019

Looking in on projects.json again, I realized that you have python projects specified as type=pypi. I'll need to go back through and update my code to match before submitting.

I'll make those changes, and find a profile that can be used to demo Python support later this evening,.

@DuaneOBrien

This comment has been minimized.

Copy link
Contributor Author

commented Oct 6, 2019

I've been able to confirm this with both local test requirements.txt files, and by referencing the following Owners/Organizations on GitHub:

https://github.com/codeforamerica
https://github.com/City-of-Helsinki/
https://github.com/uktrade/

@DuaneOBrien DuaneOBrien marked this pull request as ready for review Oct 6, 2019
@znarf
znarf approved these changes Oct 13, 2019
@znarf znarf requested a review from flickz Oct 13, 2019
@znarf

This comment has been minimized.

Copy link
Member

commented Oct 13, 2019

@flickz can you review and merge/deploy if everything is good for you?

@flickz
flickz approved these changes Oct 14, 2019
Copy link
Contributor

left a comment

LGTM, thanks @DuaneOBrien

@flickz flickz merged commit 0391fae into opencollective:master Oct 14, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
now Deployment has completed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.