Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken images links #44

Closed
Betree opened this issue Nov 19, 2019 · 3 comments
Closed

Broken images links #44

Betree opened this issue Nov 19, 2019 · 3 comments
Assignees
Labels
bug

Comments

@Betree
Copy link
Member

@Betree Betree commented Nov 19, 2019

There are broken images in the documentation, see https://docs.opencollective.com/help/financial-contributors/organizations/gift-cards#faq for example.

Problem seems to come from a3ece2d#diff-0453d5dcc4be328ac7fe8a9c43ba2a4c. Git seems to say I've made some of these changes, but I haven't renamed these files.

@contraexemplo any idea of what could be the reason?

@contraexemplo

This comment has been minimized.

Copy link
Contributor

@contraexemplo contraexemplo commented Nov 19, 2019

This is a problem I'm aware of and I'm slowly solving as I review the content of every page. Design docs had a similar issue, every image was broken for some reason. I didn't find a pattern that would help me understand why a few images broke while others didn't; it seems to be pretty random, actually. Maybe it was a change on how they handle images? They changed a few things internally this month (see https://blog.gitbook.com/changelog).

It's a really slow issue to solve as they don't link images directly from our repository, I have to double check the raw content to see the names of all broken images to restore them through GitBook's interface. You can follow my progress here: https://gist.github.com/contraexemplo/96a08878f498a7c49b118f18c8ffc8e4

I've found that following changes through Git isn't reliable at all. They state in their documentation that Git serves just as a mirror; the versioning system they use internally was designed by them. One thing that happened to me earlier this week was that GitBook restored some images I deleted and created copies of some I repeatedly used in the same page. I'm not sure why they did that either. 🤷‍♂

@contraexemplo contraexemplo added the bug label Nov 19, 2019
@contraexemplo contraexemplo self-assigned this Nov 19, 2019
@contraexemplo

This comment has been minimized.

Copy link
Contributor

@contraexemplo contraexemplo commented Nov 19, 2019

@contraexemplo

This comment has been minimized.

Copy link
Contributor

@contraexemplo contraexemplo commented Nov 19, 2019

I discovered something interesting: some of the broken images had their names modified on GitBook. For instance, screen-shot-2019-05-23-at-1.01.51-pm.png was rewritten as Screen Shot 2019-05-23 at 1.01.51 PM.png. This happened with both images on https://docs.opencollective.com/help/internal/projects/maintainerati-berlin-2019.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.