Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable "Updates" section on organization #3567

Merged
merged 19 commits into from Mar 24, 2020
Merged

Enable "Updates" section on organization #3567

merged 19 commits into from Mar 24, 2020

Conversation

xdamman
Copy link
Contributor

@xdamman xdamman commented Feb 21, 2020

Fixes opencollective/opencollective#2914

Allow admins to enable the "Updates" section on the profile page of their organization.

Also changed the "Post Update" button to "Preview Update" to avoid confusion since it is actually not posting it, but it goes to another page where you still need to post it (we ran into this ourselves)

@render
Copy link

render bot commented Feb 21, 2020

@vercel
Copy link

vercel bot commented Feb 21, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/opencollective/opencollective-frontend/jlgtrbohgz
✅ Preview: In Progress

@render
Copy link

render bot commented Feb 21, 2020

Your Render PR Server at https://oc-styleguide-pr-3567.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-bp7roe88atn4v783rcq0.

@xdamman
Copy link
Contributor Author

xdamman commented Feb 25, 2020

@mhulet can you check why the e2e tests don't pass?
Here is the error:

Copy link
Member

@Betree Betree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

components/edit-collective/EditCollectiveUpdates.js Outdated Show resolved Hide resolved
@Betree Betree self-assigned this Mar 20, 2020
@Betree Betree requested a review from znarf March 20, 2020 08:53
Co-Authored-By: Benjamin Piouffle <benjamin.piouffle@gmail.com>
@xdamman
Copy link
Contributor Author

xdamman commented Mar 22, 2020

Any idea why the lang check fails? What's the process for this?

@Betree
Copy link
Member

Betree commented Mar 23, 2020

It's because the languages files are not up to date (see https://github.com/opencollective/opencollective-frontend/pull/3567/checks?check_run_id=524532975). You can fix that with a npm run build:langs.

@xdamman
Copy link
Contributor Author

xdamman commented Mar 23, 2020

I did that before but just did it again to be sure. Still the same test failing.

@Betree
Copy link
Member

Betree commented Mar 24, 2020

It's passing now. The reason why you had to do it again is because we updated a default message in b6d8f5b.

image

@Betree
Copy link
Member

Betree commented Mar 24, 2020

All green, this is going live. Thanks @xdamman!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable "Updates" for organizations
3 participants