Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'copy link' copies wrong link #6758

Closed
alanna opened this issue May 17, 2023 · 4 comments
Closed

'copy link' copies wrong link #6758

alanna opened this issue May 17, 2023 · 4 comments

Comments

@alanna
Copy link
Contributor

alanna commented May 17, 2023

If you open an expense in the side pane and use the 'copy link' action, it should copy the link to the expense itself (blue) but it actually copies the link to the main page the side pane opened from (green).

Screen Shot 2023-05-17 at 3 12 32 PM
@Betree
Copy link
Member

Betree commented May 17, 2023

Related: #6752

@Betree
Copy link
Member

Betree commented May 17, 2023

@alanna Since we're going to work on this soon, your feedback would be super valuable: a pattern has been proposed in #6752 (comment) where copying that link will give you something like https://opencollective.com/dashboard/my-host/expenses/4242. This link will then redirect:

  • a logged-in fiscal host admin to the expense in the fiscal host workspace
  • a logged-in collective admin to the expense in the collective workspace
  • a logged-in expense submitter to their individual workspace to the expense.
  • other logged-in users (not belonging to the context of this expense) to the public expense
  • a logged-out user to the public expense

@alanna as a fiscal host admin, what would be your expectation when copying this link?

@alanna
Copy link
Contributor Author

alanna commented May 17, 2023

I'll reply over on the other issue

@Betree
Copy link
Member

Betree commented Jul 7, 2023

This was done in opencollective/opencollective-frontend#8933

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants