Skip to content

Update gNMI-1.17#5491

Merged
AmrNJ merged 3 commits into
mainfrom
AmrNJ-patch-1
May 20, 2026
Merged

Update gNMI-1.17#5491
AmrNJ merged 3 commits into
mainfrom
AmrNJ-patch-1

Conversation

@AmrNJ
Copy link
Copy Markdown
Contributor

@AmrNJ AmrNJ commented May 20, 2026

  1. Adding the existing deviation skip_controller_card_power_admin to skip ControllerCardSwitchover subtest as it is not supported.
  2. Add gnmi.Watch over gnmi.Get to accomodate delays in telemetry leaf population.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the test metadata for the controller card redundancy test to account for platform-specific limitations and improve test reliability. By adding a deviation for the Nokia platform, the test suite now correctly skips an unsupported subtest, while the transition to gnmi.Watch ensures better handling of telemetry data latency.

Highlights

  • Platform Exception Added: Added the skip_controller_card_power_admin deviation for the Nokia platform to correctly bypass an unsupported subtest.
  • Telemetry Polling Improvement: Transitioned from gnmi.Get to gnmi.Watch to improve reliability when dealing with delays in telemetry leaf population.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@AmrNJ AmrNJ changed the title Update metadata.textproto Update gNMI-1.17 May 20, 2026
@OpenConfigBot
Copy link
Copy Markdown

OpenConfigBot commented May 20, 2026

Pull Request Functional Test Report for #5491 / 7c7e578

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
gNMI-1.17: Controller card redundancy test
8f0ab885 Log
Cisco 8000E status
gNMI-1.17: Controller card redundancy test
c254e5fa Log
Cisco XRd status
gNMI-1.17: Controller card redundancy test
2ad435b1 Log
Juniper ncPTX status
gNMI-1.17: Controller card redundancy test
3190d693 Log
Nokia SR Linux status
gNMI-1.17: Controller card redundancy test
3b1e2da8 Log
Openconfig Lemming status
gNMI-1.17: Controller card redundancy test
301abbbb Log

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
gNMI-1.17: Controller card redundancy test
Cisco 8808 status
gNMI-1.17: Controller card redundancy test
Juniper PTX10008 status
gNMI-1.17: Controller card redundancy test
Nokia 7250 IXR-10e status
gNMI-1.17: Controller card redundancy test

Help

@AmrNJ AmrNJ marked this pull request as ready for review May 20, 2026 05:48
@AmrNJ AmrNJ requested a review from a team as a code owner May 20, 2026 05:48
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a platform exception for Nokia in the metadata.textproto file, introducing a deviation to skip controller card power administration. Feedback indicates that the Go test code modifications mentioned in the PR description are missing from the patch. Additionally, the reviewer pointed out that using a deviation to skip a subtest violates the repository's deviation guidelines, which prohibit using deviations to skip validations or change the intent of a test.

@AmrNJ AmrNJ merged commit fe3288b into main May 20, 2026
17 of 19 checks passed
@AmrNJ AmrNJ deleted the AmrNJ-patch-1 branch May 20, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants