Update gNMI-1.17#5491
Conversation
AmrNJ
commented
May 20, 2026
- Adding the existing deviation skip_controller_card_power_admin to skip ControllerCardSwitchover subtest as it is not supported.
- Add gnmi.Watch over gnmi.Get to accomodate delays in telemetry leaf population.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the test metadata for the controller card redundancy test to account for platform-specific limitations and improve test reliability. By adding a deviation for the Nokia platform, the test suite now correctly skips an unsupported subtest, while the transition to gnmi.Watch ensures better handling of telemetry data latency. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Pull Request Functional Test Report for #5491 / 7c7e578Virtual Devices
Hardware Devices
|
There was a problem hiding this comment.
Code Review
This pull request adds a platform exception for Nokia in the metadata.textproto file, introducing a deviation to skip controller card power administration. Feedback indicates that the Go test code modifications mentioned in the PR description are missing from the patch. Additionally, the reviewer pointed out that using a deviation to skip a subtest violates the repository's deviation guidelines, which prohibit using deviations to skip validations or change the intent of a test.