Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

migrated to airbrake from hoptoad

cleaned up data importing tasks
removed some deprecated stuff
  • Loading branch information...
commit c6ce544b56ee576fda52f0fdbf92d7417174030b 1 parent 6dfaa81
aross aross authored
Showing with 77 additions and 1,794 deletions.
  1. +1 −1  Gemfile
  2. +4 −4 Gemfile.lock
  3. +20 −10 README.md
  4. +5 −1 bin/daily/daily_parse_people.rb
  5. +25 −12 bin/daily/govtrack-rsync.sh
  6. +1 −1  config/api_keys.yml
  7. +6 −5 config/application_settings.yml
  8. +4 −7 config/deploy.rb
  9. +5 −0 config/initializers/airbrake.rb
  10. +0 −3  config/initializers/hoptoad.rb
  11. +6 −2 lib/tasks/daily.rake
  12. +0 −25 lib/tasks/hoptoad_notifier_tasks.rake
  13. +0 −20 vendor/plugins/rails_upgrade/MIT-LICENSE
  14. +0 −20 vendor/plugins/rails_upgrade/README
  15. +0 −22 vendor/plugins/rails_upgrade/Rakefile
  16. +0 −2  vendor/plugins/rails_upgrade/init.rb
  17. +0 −38 vendor/plugins/rails_upgrade/install.rb
  18. +0 −472 vendor/plugins/rails_upgrade/lib/application_checker.rb
  19. +0 −95 vendor/plugins/rails_upgrade/lib/gemfile_generator.rb
  20. +0 −51 vendor/plugins/rails_upgrade/lib/new_configuration_generator.rb
  21. 0  vendor/plugins/rails_upgrade/lib/rails_upgrade.rb
  22. +0 −349 vendor/plugins/rails_upgrade/lib/routes_upgrader.rb
  23. +0 −78 vendor/plugins/rails_upgrade/lib/tasks/rails_upgrade_tasks.rake
  24. +0 −293 vendor/plugins/rails_upgrade/test/application_checker_test.rb
  25. +0 −72 vendor/plugins/rails_upgrade/test/gemfile_generator_test.rb
  26. +0 −63 vendor/plugins/rails_upgrade/test/new_configuration_generator_test.rb
  27. +0 −142 vendor/plugins/rails_upgrade/test/routes_upgrader_test.rb
  28. +0 −5 vendor/plugins/rails_upgrade/test/test_helper.rb
  29. +0 −1  vendor/plugins/rails_upgrade/uninstall.rb
2  Gemfile
View
@@ -40,7 +40,7 @@ gem 'paperclip'
# notifier for production errors
-gem "hoptoad_notifier"
+gem "airbrake"
gem "xray", :require => "xray/thread_dump_signal_handler"
# OpenID
8 Gemfile.lock
View
@@ -56,6 +56,9 @@ GEM
activesupport (= 3.0.7)
activesupport (3.0.7)
addressable (2.2.6)
+ airbrake (3.0.9)
+ activesupport
+ builder
arel (2.0.10)
autotest (4.4.6)
ZenTest (>= 4.4.1)
@@ -141,9 +144,6 @@ GEM
railties (~> 3.0)
hashie (1.1.0)
highline (1.6.2)
- hoptoad_notifier (2.4.11)
- activesupport
- builder
hpricot (0.8.4)
htmlentities (4.3.0)
httmultiparty (0.3.6)
@@ -281,6 +281,7 @@ PLATFORMS
DEPENDENCIES
RedCloth
acts-as-taggable-on!
+ airbrake
autotest
bluecloth
capistrano
@@ -299,7 +300,6 @@ DEPENDENCIES
guard-livereload
haml
haml-rails
- hoptoad_notifier
hpricot
htmlentities
jammit
30 README.md
View
@@ -34,34 +34,44 @@ Follow the instructions after the packages install for initializing your databas
Install the bundle:
-<pre>
<code>
[sudo] gem install bundler
bundle install
</code>
-</pre>
__Note for OS X:__ *You may need to specify additional compile options for your gems. Try: `ARCHFLAGS="-arch x86_64" bundle install`
### B. Database setup
Running the following commands will create an 'opencongress' user and empty databases for the three environments (test, development, production). The migration command will populate the development database with an empty schema.
-<pre>
+
<code>
rake db:init
rake db:migrate
</code>
-</pre>
-### C. Data (optional)
+### C. Solr (optional, recommended)
-We are developing a process to quickly import some real legislative data. Coming soon.
-
-### D. Starting the server
-
-OpenCongress uses Solr to store some data. The following command is not required, but some pages will break if Solr is not running:
+OpenCongress uses Solr to store some data. Running Solr is not required to run the web server, but some pages will break if Solr is not running. If you are going to import data, running solr is required or you will encounter errors.
+
+You can run Solr with the following command (usually in the background and/or in a separate window):
rake solr:start
+
+
+### D. Legislative Data (optional)
+
+See note above about running Solr: it is required for importing data.
+
+To import legislative data into your database, run the following command:
+
+ rake update:govtrack
+
+This will download data files from [Govtrack](http://govtrack.us) and import them into your database. The default location for storage of the data files is `/tmp/opencongress_data` but you can change this by editing `config/application_settings.yml`. This task will import ALL of the data for the current session of Congress: it will take a long time and occupy a LOT of space on your filesystem! Keep this in mind before importing the data!
+
+### E. Starting the server
+
+See note above about running Solr: it is not required, but recommended.
To start the webserver:
6 bin/daily/daily_parse_people.rb
View
@@ -53,6 +53,8 @@ def tag_end(name)
end
def make_person(attrs)
+
+
id = attrs['id'].to_i
arr = @people[id]
@person = arr[0] unless arr.nil?
@@ -92,6 +94,8 @@ def make_person(attrs)
@person.district = attrs['district']
@person.state = attrs['state']
@person.email = attrs['email']
+
+ puts "Legislator: #{@person.name}, birthday: #{@person.birthday}"
end
def make_role(as)
@@ -154,7 +158,7 @@ def method_missing(*args)
end
end
-puts "people parsed"
+puts "Parsing All Legislators from govtrack file..."
Person.transaction {
source = File.open(Settings.govtrack_data_path + "/#{Settings.default_congress}/../people.xml")
37 bin/daily/govtrack-rsync.sh
View
@@ -3,24 +3,37 @@ if [ -d "$1" ]
then
data=$1
else
- echo 'data dir not found! fix DATA_PATH in your environment file'
- exit
+ echo 'data dir not found! trying to create file...'
+ mkdir -p $1
+
+ if [ ! -d "$1" ]
+ then
+ echo 'could not create $1!'
+ exit
+ fi
+
+ data=$1
+fi
+
+if [ ! -d "$data/govtrack" ]
+then
+ mkdir -p $data/govtrack
fi
-if [ ! -d "$data/govtrack/log" ]
+if [ ! -d "$data/govtrack/bills.text" ]
then
- mkdir -p $data/govtrack/log
+ mkdir -p $data/govtrack/bills.text
fi
-if [ ! -e "$data/govtrack/log/govtrack-rsync.log" ]
+if [ ! -d "$data/govtrack/bills.text.cmp" ]
then
- touch $data/govtrack/log/govtrack-rsync.log
+ mkdir -p $data/govtrack/bills.text.cmp
fi
-cd $data/govtrack
+cd $data
-echo "\n\nrsyncing govtrack at `date`" >> log/govtrack-rsync.log
-rsync -avz govtrack.us::govtrackdata/us/people.xml . >> log/govtrack-rsync.log
-rsync -avz --exclude '*.pdf' --exclude '*.png' govtrack.us::govtrackdata/us/112 . >> log/govtrack-rsync.log
-rsync -avz --exclude '*.pdf' govtrack.us::govtrackdata/us/bills.text/112 ./bills.text/ >> log/govtrack-rsync.log
-rsync -avz govtrack.us::govtrackdata/us/bills.text.cmp/112 ./bills.text.cmp/ >> log/govtrack-rsync.log
+echo "\n\nrsyncing govtrack at `date`"
+rsync -avz govtrack.us::govtrackdata/us/people.xml ./govtrack/
+rsync -avz --exclude '*.pdf' --exclude '*.png' govtrack.us::govtrackdata/us/112 ./govtrack/
+rsync -avz --exclude '*.pdf' govtrack.us::govtrackdata/us/bills.text/112 ./govtrack/bills.text/
+rsync -avz govtrack.us::govtrackdata/us/bills.text.cmp/112 ./govtrack/bills.text.cmp/
2  config/api_keys.yml
View
@@ -15,7 +15,7 @@ defaults: &defaults
civicrm_user_key: xxx
project_vote_smart: xxx
google_maps: xxx
- hoptoad: xxx
+ airbrake: xxx
bitly: xxx
aws_access_key_id: xxx
aws_secret_access_key: xxx
11 config/application_settings.yml
View
@@ -41,11 +41,12 @@ defaults: &defaults
development:
<<: *defaults
- govtrack_data_path: /Users/aross/pcf-work/govtrack_data/us
- govtrack_billtext_path: /Users/aross/pcf-work/govtrack_data/us/bills.text
- govtrack_billtext_diff_path: /Users/aross/pcf-work/govtrack_data/us/bills.text.cmp
- oc_billtext_path: /Users/aross/pcf-work/oc_billtext
- committee_reports_path: /Users/aross/pcf-work/committee_reports
+ data_path: /tmp/opencongress_data
+ govtrack_data_path: /tmp/opencongress_data/govtrack
+ govtrack_billtext_path: /tmp/opencongress_data/govtrack/bills.text
+ govtrack_billtext_diff_path: /tmp/opencongress_data/govtrack/bills.text.cmp
+ oc_billtext_path: /tmp/opencongress_data/opencongress/bills.text
+ committee_reports_path: /tmp/opencongress_data/committee_reports
group_images_path: <%= Rails.root %>/public/system/group_images
notebook_files_path: <%= Rails.root %>/public/system/notebook_files
11 config/deploy.rb
View
@@ -51,7 +51,7 @@
run "ln -s #{deploy_to}/#{shared_dir}/files/oc_whats.flv #{current_release}/public/oc_whats.flv"
run "ln -s #{deploy_to}/#{shared_dir}/files/screencast.mp4 #{current_release}/public/screencast.mp4"
run "ln -s #{deploy_to}/#{shared_dir}/files/facebook.yml #{current_release}/config/"
-# sudo "chown -R mongrel:admins #{current_release}"
+ # sudo "chown -R mongrel:admins #{current_release}"
end
desc "Compile CSS & JS for public/assets/ (see assets.yml)"
@@ -80,9 +80,6 @@
after "deploy:update_code", "deploy:jammit"
-# HopToad notification.
-Dir[File.join(File.dirname(__FILE__), '..', 'vendor', 'gems', 'hoptoad_notifier-*')].each do |vendored_notifier|
- $: << File.join(vendored_notifier, 'lib')
-end
-
-require 'hoptoad_notifier/capistrano'
+# Airbrake put the following in; necessary?
+#require './config/boot'
+require 'airbrake/capistrano'
5 config/initializers/airbrake.rb
View
@@ -0,0 +1,5 @@
+require 'config/initializers/api_keys'
+
+Airbrake.configure do |config|
+ config.api_key = ApiKeys.airbrake
+end
3  config/initializers/hoptoad.rb
View
@@ -1,3 +0,0 @@
-HoptoadNotifier.configure do |config|
- config.api_key = ApiKeys.hoptoad
-end
8 lib/tasks/daily.rake
View
@@ -62,9 +62,13 @@ namespace :update do
task :people => :environment do
begin
- data = IO.popen("sha1sum -c /tmp/people.sha1").read
+ begin
+ data = IO.popen("sha1sum -c /tmp/people.sha1").read
+ rescue
+ data = "XXX"
+ end
+
unless data.match(/OK\n$/)
- system "sha1sum #{Settings.data_path}/govtrack/people.xml >/tmp/people.sha1"
Person.transaction {
load 'bin/daily/daily_parse_people.rb'
}
25 lib/tasks/hoptoad_notifier_tasks.rake
View
@@ -1,25 +0,0 @@
-# Don't load anything when running the gems:* tasks.
-# Otherwise, hoptoad_notifier will be considered a framework gem.
-# https://thoughtbot.lighthouseapp.com/projects/14221/tickets/629
-unless ARGV.any? {|a| a =~ /^gems/}
-
- Dir[File.join(Rails.root.to_s, 'vendor', 'gems', 'hoptoad_notifier-*')].each do |vendored_notifier|
- $: << File.join(vendored_notifier, 'lib')
- end
-
- begin
- require 'hoptoad_notifier/tasks'
- rescue LoadError => exception
- namespace :hoptoad do
- %w(deploy test log_stdout).each do |task_name|
- desc "Missing dependency for hoptoad:#{task_name}"
- task task_name do
- $stderr.puts "Failed to run hoptoad:#{task_name} because of missing dependency."
- $stderr.puts "You probably need to run `rake gems:install` to install the hoptoad_notifier gem"
- abort exception.inspect
- end
- end
- end
- end
-
-end
20 vendor/plugins/rails_upgrade/MIT-LICENSE
View
@@ -1,20 +0,0 @@
-Copyright (c) 2010 Jeremy McAnally
-
-Permission is hereby granted, free of charge, to any person obtaining
-a copy of this software and associated documentation files (the
-"Software"), to deal in the Software without restriction, including
-without limitation the rights to use, copy, modify, merge, publish,
-distribute, sublicense, and/or sell copies of the Software, and to
-permit persons to whom the Software is furnished to do so, subject to
-the following conditions:
-
-The above copyright notice and this permission notice shall be
-included in all copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
-EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
-MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
-NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
-LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
-OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
-WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
20 vendor/plugins/rails_upgrade/README
View
@@ -1,20 +0,0 @@
-= rails-upgrade
-
-A simple battery of scripts for upgrading Rails app/checking them for required updates. This application should work on Rails 2.x and 3.0, with a focus on upgrading to 3.0.
-
-== Usage
-
- # Check your app for required upgrades
- rake rails:upgrade:check
-
- # Backup your likely modified files that might be overwritten by the generator
- rake rails:upgrade:backup
-
- # Generate a new route file
- rake rails:upgrade:routes
-
- # Generate a Gemfile from your config.gem directives
- rake rails:upgrade:gems
-
- # Generate code for a new config/application.rb from your environment.rb
- rake rails:upgrade:configuration
22 vendor/plugins/rails_upgrade/Rakefile
View
@@ -1,22 +0,0 @@
-require 'rake'
-require 'rake/testtask'
-require 'rake/rdoctask'
-
-desc 'Default: run unit tests.'
-task :default => :test
-
-Rake::TestTask.new do |t|
- t.libs << 'lib'
- t.libs << 'test'
- t.test_files = FileList['test/*_test.rb']
- t.verbose = true
-end
-
-desc 'Generate documentation for the rails_upgrade plugin.'
-Rake::RDocTask.new(:rdoc) do |rdoc|
- rdoc.rdoc_dir = 'rdoc'
- rdoc.title = 'Rails-upgrade'
- rdoc.options << '--line-numbers' << '--inline-source'
- rdoc.rdoc_files.include('README')
- rdoc.rdoc_files.include('lib/**/*.rb')
-end
2  vendor/plugins/rails_upgrade/init.rb
View
@@ -1,2 +0,0 @@
-# Get long stack traces for easier debugging; you'll thank me later.
-Rails.backtrace_cleaner.remove_silencers!
38 vendor/plugins/rails_upgrade/install.rb
View
@@ -1,38 +0,0 @@
-puts "Thanks for installing the Rails upgrade plugin. This is a set of generators and analysis tools to help you upgrade your application to Rails 3. It consists of three tasks...
-
-To get a feel for what you'll need to change to get your app running, run the application analysis:
-
- rake rails:upgrade:check
-
-This should give you an idea of the manual changes that need to be done, but you'll probably want to upgrade some of those automatically. The fastest way to do this is to run 'rails .', which will simply generate a new app on top of your existing code. But this generation also has the effect of replacing some existing files, some of which you might not want to replace. To back those up, first run:
-
- rake rails:upgrade:backup
-
-That will backup files you've probably edited that will be replaced in the upgrade; if you finish the upgrade and find that you don't need the old copies, just delete them. Otherwise, copy their contents back into the new files or run one of the following upgraders...
-
-Routes upgrader
-===============
-
-To generate a new routes file from your existing routes file, simply run the following Rake task:
-
- rake rails:upgrade:routes
-
-This will output a new routes file that you can copy and paste or pipe into a new, Rails 3 compatible config/routes.rb.
-
-Gemfile generator
-=================
-
-Creating a new Gemfile is as simple as running:
-
- rake rails:upgrade:gems
-
-This task will extract your config.gem calls and generate code you can put into a bundler compatible Gemfile.
-
-Configuration generator
-=======================
-
-Much of the configuration information that lived in environment.rb now belongs in a new file named config/application.rb; use the following task to generate code you can put into config/application.rb from your existing config/environment.rb:
-
- rake rails:upgrade:configuration
-
-"
472 vendor/plugins/rails_upgrade/lib/application_checker.rb
View
@@ -1,472 +0,0 @@
-require 'open3'
-
-module Rails
- module Upgrading
- class ApplicationChecker
- def initialize
- @issues = []
-
- raise NotInRailsAppError unless in_rails_app?
- end
-
- def in_rails_app?
- File.exist?("config/environment.rb")
- end
-
- # Run all the check methods
- def run
- # Ruby 1.8 returns method names as strings whereas 1.9 uses symbols
- the_methods = (self.public_methods - Object.methods) - [:run, :initialize, "run", "initialize"]
-
- the_methods.each {|m| send m }
- end
-
- # Check for deprecated ActiveRecord calls
- def check_ar_methods
- files = []
- ["find(:all", "find(:first", "find.*:conditions =>", ":joins =>"].each do |v|
- lines = grep_for(v, "app/")
- files += extract_filenames(lines) || []
- end
-
- unless files.empty?
- alert(
- "Soon-to-be-deprecated ActiveRecord calls",
- "Methods such as find(:all), find(:first), finds with conditions, and the :joins option will soon be deprecated.",
- "http://m.onkey.org/2010/1/22/active-record-query-interface",
- files
- )
- end
-
- lines = grep_for("named_scope", "app/models/")
- files = extract_filenames(lines)
-
- if files
- alert(
- "named_scope is now just scope",
- "The named_scope method has been renamed to just scope.",
- "http://github.com/rails/rails/commit/d60bb0a9e4be2ac0a9de9a69041a4ddc2e0cc914",
- files
- )
- end
- end
-
- def check_validation_on_methods
- files = []
-
- ["validate_on_create", "validate_on_update"].each do |v|
- lines = grep_for(v, "app/models/")
- files += extract_filenames(lines) || []
- end
-
- unless files.empty?
- alert(
- "Updated syntax for validate_on_* methods",
- "Validate-on-callback methods (validate_on_create/validate_on_destroy) have been changed to validate :x, :on => :create",
- "https://rails.lighthouseapp.com/projects/8994/tickets/3880-validate_on_create-and-validate_on_update-no-longer-seem-to-exist",
- files
- )
- end
- end
-
- def check_before_validation_on_methods
- files = []
-
- %w(before_validation_on_create before_validation_on_update).each do |v|
- lines = grep_for(v, "app/models/")
- files += extract_filenames(lines) || []
- end
-
- unless files.empty?
- alert(
- "Updated syntax for before_validation_on_* methods",
- "before_validation_on_* methods have been changed to before_validation(:on => :create/:update) { ... }",
- "https://rails.lighthouseapp.com/projects/8994/tickets/4699-before_validation_on_create-and-before_validation_on_update-doesnt-exist",
- files
- )
- end
- end
-
- # Check for deprecated router syntax
- def check_routes
- lines = ["map\\.", "ActionController::Routing::Routes", "\\.resources"].map do |v|
- grep_for(v, "config/routes.rb").empty? ? nil : true
- end.compact
-
- unless lines.empty?
- alert(
- "Old router API",
- "The router API has totally changed.",
- "http://yehudakatz.com/2009/12/26/the-rails-3-router-rack-it-up/",
- "config/routes.rb"
- )
- end
- end
-
- # Check for deprecated test_help require
- def check_test_help
- files = []
-
- # Hate to duplicate code, but we have to double quote this one...
- lines = grep_for("\'test_help\'", "test/", true)
- files += extract_filenames(lines) || []
-
- lines = grep_for("\"test_help\"", "test/")
- files += extract_filenames(lines) || []
-
- files.uniq!
-
- unless files.empty?
- alert(
- "Deprecated test_help path",
- "You now must require 'rails/test_help' not just 'test_help'.",
- "http://weblog.rubyonrails.org/2009/9/1/gem-packaging-best-practices",
- files
- )
- end
- end
-
- # Check for old (pre-application.rb) environment.rb file
- def check_environment
- unless File.exist?("config/application.rb")
- alert(
- "New file needed: config/application.rb",
- "You need to add a config/application.rb.",
- "http://omgbloglol.com/post/353978923/the-path-to-rails-3-approaching-the-upgrade",
- "config/application.rb"
- )
- end
-
- lines = grep_for("config.", "config/environment.rb")
-
- unless lines.empty?
- alert(
- "Old environment.rb",
- "environment.rb doesn't do what it used to; you'll need to move some of that into application.rb.",
- "http://omgbloglol.com/post/353978923/the-path-to-rails-3-approaching-the-upgrade",
- "config/environment.rb"
- )
- end
- end
-
- # Check for deprecated constants
- def check_deprecated_constants
- files = []
- ["RAILS_ENV", "RAILS_ROOT", "RAILS_DEFAULT_LOGGER"].each do |v|
- lines = grep_for(v, "app/")
- files += extract_filenames(lines) || []
-
- lines = grep_for(v, "lib/")
- files += extract_filenames(lines) || []
- end
-
- unless files.empty?
- alert(
- "Deprecated constant(s)",
- "Constants like RAILS_ENV, RAILS_ROOT, and RAILS_DEFAULT_LOGGER are now deprecated.",
- "http://litanyagainstfear.com/blog/2010/02/03/the-rails-module/",
- files.uniq
- )
- end
- end
-
- # Check for old-style config.gem calls
- def check_gems
- lines = grep_for("config.gem ", "config/*.rb")
- files = extract_filenames(lines)
-
- if files
- alert(
- "Old gem bundling (config.gems)",
- "The old way of bundling is gone now. You need a Gemfile for bundler.",
- "http://omgbloglol.com/post/353978923/the-path-to-rails-3-approaching-the-upgrade",
- files
- )
- end
- end
-
- # Checks for old mailer syntax in both mailer classes and those
- # classes utilizing the mailers
- def check_mailers
- lines = grep_for("deliver_", "app/models/ #{base_path}app/controllers/ #{base_path}app/observers/")
- files = extract_filenames(lines)
-
- if files
- alert(
- "Deprecated ActionMailer API",
- "You're using the old ActionMailer API to send e-mails in a controller, model, or observer.",
- "http://lindsaar.net/2010/1/26/new-actionmailer-api-in-rails-3",
- files
- )
- end
-
- files = []
- ["recipients ", "attachment(?!s) ", "(?<!:)subject ", "(?<!:)from "].each do |v|
- lines = grep_for_with_perl_regex(v, "app/models/")
- files += extract_filenames(lines) || []
- end
-
- unless files.empty?
- alert(
- "Old ActionMailer class API",
- "You're using the old API in a mailer class.",
- "http://lindsaar.net/2010/1/26/new-actionmailer-api-in-rails-3",
- files
- )
- end
- end
-
- # Checks for old-style generators
- def check_generators
- generators = Dir.glob(base_path + "vendor/plugins/**/generators/**/")
-
- unless generators.empty?
- files = generators.reject do |g|
- grep_for("def manifest", g).empty?
- end.compact
-
- if !files.empty?
- alert(
- "Old Rails generator API",
- "A plugin in the app is using the old generator API (a new one may be available at http://github.com/trydionel/rails3-generators).",
- "http://blog.plataformatec.com.br/2010/01/discovering-rails-3-generators/",
- files
- )
- end
- end
- end
-
- # Checks a list of known broken plugins and gems
- def check_plugins
- # This list is off the wiki; will need to be updated often, esp. since RSpec is working on it
- bad_plugins = ["rspec", "rspec-rails", "hoptoad", "authlogic", "nifty-generators",
- "restful_authentication", "searchlogic", "cucumber", "cucumber-rails", "devise",
- "inherited_resources"]
-
- bad_plugins = bad_plugins.map do |p|
- p if File.exist?("#{base_path}vendor/plugins/#{p}") || !Dir.glob("#{base_path}vendor/gems/#{p}-*").empty?
- end.compact
-
- unless bad_plugins.empty?
- alert(
- "Known broken plugins",
- "At least one plugin in your app is broken (according to the wiki). Most of project maintainers are rapidly working towards compatability, but do be aware you may encounter issues.",
- "http://wiki.rubyonrails.org/rails/version3/plugins_and_gems",
- bad_plugins
- )
- end
- end
-
- # Checks for old-style ERb helpers
- def check_old_helpers
-
- lines = grep_for("<% .*content_tag.* do.*%>", "app/views/**/*")
- lines += grep_for("<% .*javascript_tag.* do.*%>", "app/views/**/*")
- lines += grep_for("<% .*form_for.* do.*%>", "app/views/**/*")
- lines += grep_for("<% .*form_tag.* do.*%>", "app/views/**/*")
- lines += grep_for("<% .*fields_for.* do.*%>", "app/views/**/*")
- lines += grep_for("<% .*field_set_tag.* do.*%>", "app/views/**/*")
-
- files = extract_filenames(lines)
-
- if files
- alert(
- "Deprecated ERb helper calls",
- "Block helpers that use concat (e.g., form_for) should use <%= instead of <%. The current form will continue to work for now, but you will get deprecation warnings since this form will go away in the future.",
- "http://weblog.rubyonrails.org/",
- files
- )
- end
- end
-
- # Checks for old-style AJAX helpers
- def check_old_ajax_helpers
- files = []
- ['link_to_remote','form_remote_tag','remote_form_for'].each do |type|
- lines = grep_for(type, "app/views/**/*")
- inner_files = extract_filenames(lines)
- files += inner_files unless inner_files.nil?
- end
-
- unless files.empty?
- alert(
- "Deprecated AJAX helper calls",
- "AJAX javascript helpers have been switched to be unobtrusive and use :remote => true instead of having a seperate function to handle remote requests.",
- "http://www.themodestrubyist.com/2010/02/24/rails-3-ujs-and-csrf-meta-tags/",
- files
- )
- end
- end
-
- # Checks for old cookie secret settings
- def check_old_cookie_secret
- lines = grep_for("ActionController::Base.cookie_verifier_secret = ", "config/**/*")
- files = extract_filenames(lines)
-
- if files
- alert(
- "Deprecated cookie secret setting",
- "Previously, cookie secret was set directly on ActionController::Base; it's now config.secret_token.",
- "http://lindsaar.net/2010/4/7/rails_3_session_secret_and_session_store",
- files
- )
- end
- end
-
- def check_old_session_secret
- lines = grep_for("ActionController::Base.session = {", "config/**/*")
- files = extract_filenames(lines)
-
- if files
- alert(
- "Deprecated session secret setting",
- "Previously, session secret was set directly on ActionController::Base; it's now config.secret_token.",
- "http://lindsaar.net/2010/4/7/rails_3_session_secret_and_session_store",
- files
- )
- end
- end
-
- # Checks for old session settings
- def check_old_session_setting
- lines = grep_for("ActionController::Base.session_store", "config/**/*")
- files = extract_filenames(lines)
-
- if files
- alert(
- "Old session store setting",
- "Previously, session store was set directly on ActionController::Base; it's now config.session_store :whatever.",
- "http://lindsaar.net/2010/4/7/rails_3_session_secret_and_session_store",
- files
- )
- end
- end
-
- private
- def grep_for_with_perl_regex(text, where = "./", double_quote = false)
- grep_for(text, where, double_quote, true)
- end
-
- # Find a string in a set of files; calls +find_with_grep+ and +find_with_rak+
- # depending on platform.
- #
- # TODO: Figure out if this works on Windows.
- def grep_for(text, where = "./", double_quote = false, perl_regex = false)
- # If they're on Windows, they probably don't have grep.
- @probably_has_grep ||= (Config::CONFIG['host_os'].downcase =~ /mswin|windows|mingw/).nil?
-
- # protect against double root paths in Rails 3
- where.gsub!(Regexp.new(base_path),'')
-
- lines = if @probably_has_grep
- find_with_grep(text, base_path + where, double_quote, perl_regex)
- else
- find_with_rak(text, base_path + where, double_quote)
- end
-
- # ignore comments
- lines.gsub /^(\/[^:]+:)?\s*#.+$/m, ""
- end
-
- # Sets a base path for finding files; mostly for testing
- def base_path
- Dir.pwd + "/"
- end
-
- # Use the grep utility to find a string in a set of files
- def find_with_grep(text, where, double_quote, perl_regex = false)
- value = ""
- # Specifically double quote for finding 'test_help'
- command = if double_quote
- "grep -r #{"-P" if perl_regex} --exclude=\*.svn\* \"#{text}\" #{where}"
- else
- "grep -r #{"-P" if perl_regex} --exclude=\*.svn\* '#{text}' #{where}"
- end
-
- Open3.popen3(command) do |stdin, stdout, stderr|
- value = stdout.read
- end
- value
- end
-
- # Use the rak gem to grep the files (not yet implemented)
- def find_with_rak(text, where, double_quote)
- value = ""
- Open3.popen3("rak --nogroup -l '#{Regexp.escape(text)}' #{where}") do |stdin, stdout, stderr|
- value = stdout.read
- end
- value
- end
-
- # Extract the filenames from the grep output
- def extract_filenames(output)
- if @probably_has_grep
- extract_filenames_from_grep(output)
- else
- extract_filenames_from_rak(output)
- end
- end
-
- def extract_filenames_from_grep(output)
- return nil if output.empty?
-
- output.split("\n").map do |fn|
- if m = fn.match(/^(.+?):/)
- m[1]
- end
- end.compact.uniq
- end
-
- def extract_filenames_from_rak(output)
- return nil if output.empty?
-
- output.split("\n").uniq
- end
-
- # Terminal colors, borrowed from Thor
- CLEAR = "\e[0m"
- BOLD = "\e[1m"
- RED = "\e[31m"
- YELLOW = "\e[33m"
- CYAN = "\e[36m"
- WHITE = "\e[37m"
-
- # Show an upgrade alert to the user
- def alert(title, text, more_info_url, culprits)
- if Config::CONFIG['host_os'].downcase =~ /mswin|windows|mingw/
- basic_alert(title, text, more_info_url, culprits)
- else
- color_alert(title, text, more_info_url, culprits)
- end
- end
-
- # Show an upgrade alert to the user. If we're on Windows, we can't
- # use terminal colors, hence this method.
- def basic_alert(title, text, more_info_url, culprits)
- puts "** " + title
- puts text
- puts "More information: #{more_info_url}"
- puts
- puts "The culprits: "
- Array(culprits).each do |c|
- puts "\t- #{c}"
- end
- puts
- end
-
- # Show a colorful alert to the user
- def color_alert(title, text, more_info_url, culprits)
- puts "#{RED}#{BOLD}#{title}#{CLEAR}"
- puts "#{WHITE}#{text}"
- puts "#{BOLD}More information:#{CLEAR} #{CYAN}#{more_info_url}"
- puts
- puts "#{WHITE}The culprits: "
- Array(culprits).each do |c|
- puts "#{YELLOW}\t- #{c}"
- end
- ensure
- puts "#{CLEAR}"
- end
- end
- end
-end
95 vendor/plugins/rails_upgrade/lib/gemfile_generator.rb
View
@@ -1,95 +0,0 @@
-module Rails
- module Upgrading
- class GemfileGenerator
- def generate_new_gemfile
- if has_environment?
- generate_gemfile
- else
- raise FileNotFoundError, "Can't find environment.rb [config/environment.rb]!"
- end
- end
-
- def has_environment?
- File.exists?("config/environment.rb")
- end
-
- def environment_code
- File.open("config/environment.rb").read
- end
-
- def generate_gemfile
- environment_file = environment_code
-
- # Get each line that starts with config.gem
- gem_lines = environment_file.split("\n").select {|l| l =~ /^\s*config\.gem/}
-
- # Toss those lines to a generator class; the lines are evaluated in the
- # context of that instance.
- config = GemfileGenerator.new
- config.instance_eval(gem_lines.join("\n"))
-
- config.output
- end
- end
-
- class GemfileGenerator
- # Creates a target for the config.gem calls
- def config
- self
- end
-
- def initialize
- @gems = []
- end
-
- # Receive a call to add a gem to the list
- def gem(name, options={})
- data = {}
-
- # Add new keys from old keys
- data[:require] = options[:lib] if options[:lib]
- data[:source] = options[:source] if options[:source]
-
- version = options[:version]
- @gems << [name, version, data]
- end
-
- # Generate the Gemfile output
- def output
- # Generic preamble, taken from Yehuda Katz's blog
- preamble = <<STR
-# Edit this Gemfile to bundle your application's dependencies.
-# This preamble is the current preamble for Rails 3 apps; edit as needed.
-source 'http://rubygems.org'
-
-gem 'rails', '3.0.0.beta3'
-
-STR
- preamble + generate_upgraded_code
- end
-
- # Get Gemfile call for all the gems
- def generate_upgraded_code
- code = @gems.map do |name, version, data|
- version_string = (version ? "'#{version}'" : nil)
- source = data.delete(:source)
-
- data_string = nil
- unless data.empty?
- data_string = data.to_a.map {|k, v| ":#{k} => '#{v}'"}.join(", ")
- end
-
- # If we have a source, generate a call to +source+ then output the
- # gem call. Otherwise, just generate the gem requirement.
- if source
- str = ["'#{name}'", version_string, data_string].compact.join(", ")
- "source '#{source}'\ngem #{str}"
- else
- str = ["'#{name}'", version_string, data_string].compact.join(", ")
- "gem #{str}"
- end
- end.join("\n")
- end
- end
- end
-end
51 vendor/plugins/rails_upgrade/lib/new_configuration_generator.rb
View
@@ -1,51 +0,0 @@
-module Rails
- module Upgrading
- class NewConfigurationGenerator
- def generate_new_configurations
- if has_environment?
- generate_new_application_rb
- else
- raise FileNotFoundError, "Can't find environment.rb [config/environment.rb]!"
- end
- end
-
- def has_environment?
- File.exists?("config/environment.rb")
- end
-
- def environment_code
- File.open("config/environment.rb").read
- end
-
- def generate_new_application_rb
- environment_file = environment_code
-
- initializer_code = ""
- if matches = environment_file.match(/Rails\:\:Initializer\.run do \|config\|\n(.*)\nend/m)
- initializer_code = matches[1]
- else
- raise "There doesn't seem to be a real environment.rb in your app. Are you sure config/environment.rb has the right contents?"
- end
-
- frame = "# Put this in config/application.rb
-require File.expand_path('../boot', __FILE__)
-
-module #{app_name.classify}
- class Application < Rails::Application
-%s
- end
-end"
-
- frame % [indent(initializer_code)]
- end
-
- def indent(text)
- text.split("\n").map {|l| " #{l}"}.join("\n")
- end
-
- def app_name
- File.basename(Dir.pwd)
- end
- end
- end
-end
0  vendor/plugins/rails_upgrade/lib/rails_upgrade.rb
View
No changes.
349 vendor/plugins/rails_upgrade/lib/routes_upgrader.rb
View
@@ -1,349 +0,0 @@
-# TODO: Fix formatting on member/collection methods
-
-module Rails
- module Upgrading
- module FakeRouter
- module ActionController
- module Routing
- class Routes
- def self.setup
- @redrawer = Rails::Upgrading::RouteRedrawer.new
- end
-
- def self.redrawer
- @redrawer
- end
-
- def self.draw
- yield @redrawer
- end
- end
- end
- end
- end
-
- class RoutesUpgrader
- def generate_new_routes
- if has_routes_file?
- upgrade_routes
- else
- raise FileNotFoundError, "Can't find your routes file [config/routes.rb]!"
- end
- end
-
- def has_routes_file?
- File.exists?("config/routes.rb")
- end
-
- def routes_code
- File.read("config/routes.rb")
- end
-
- def upgrade_routes
- FakeRouter::ActionController::Routing::Routes.setup
-
- # Read and eval the file; our fake route mapper will capture
- # the calls to draw routes and generate new route code
- FakeRouter.module_eval(routes_code)
-
- # Give the route set to the code generator and get its output
- generator = RouteGenerator.new(FakeRouter::ActionController::Routing::Routes.redrawer.routes)
- generator.generate
- end
- end
-
- class RouteRedrawer
- attr_accessor :routes
-
- def self.stack
- @stack
- end
-
- def self.stack=(val)
- @stack = val
- end
-
- def initialize
- @routes = []
-
- # The old default route was actually two routes; we generate the new style
- # one only if we haven't generated it for the first old default route.
- @default_route_generated = false
-
- # Setup the stack for parents; used use proper indentation
- self.class.stack = [@routes]
- end
-
- def root(options)
- debug "mapping root"
- @routes << FakeRoute.new("/", options)
- end
-
- def connect(path, options={})
- debug "connecting #{path}"
-
- if (path == ":controller/:action/:id.:format" || path == ":controller/:action/:id")
- if !@default_route_generated
- current_parent << FakeRoute.new("/:controller(/:action(/:id))", {:default_route => true})
-
- @default_route_generated = true
- end
- else
- current_parent << FakeRoute.new(path, options)
- end
- end
-
- def resources(*args)
- if block_given?
- parent = FakeResourceRoute.new(args.shift)
- debug "mapping resources #{parent.name} with block"
-
- parent = stack(parent) do
- yield(self)
- end
-
- current_parent << parent
- else
- if args.last.is_a?(Hash)
- current_parent << FakeResourceRoute.new(args.shift, args.pop)
- debug "mapping resources #{current_parent.last.name} w/o block with args"
- else
- args.each do |a|
- current_parent << FakeResourceRoute.new(a)
- debug "mapping resources #{current_parent.last.name}"
- end
- end
- end
- end
-
- def resource(*args)
- if block_given?
- parent = FakeSingletonResourceRoute.new(args.shift)
- debug "mapping resource #{parent.name} with block"
-
- parent = stack(parent) do
- yield(self)
- end
-
- current_parent << parent
- else
- if args.last.is_a?(Hash)
- current_parent << FakeSingletonResourceRoute.new(args.shift, args.pop)
- debug "mapping resources #{current_parent.last.name} w/o block with args"
- else
- args.each do |a|
- current_parent << FakeSingletonResourceRoute.new(a)
- debug "mapping resources #{current_parent.last.name}"
- end
- end
- end
- end
-
- def namespace(name)
- debug "mapping namespace #{name}"
- namespace = FakeNamespace.new(name)
-
- namespace = stack(namespace) do
- yield(self)
- end
-
- current_parent << namespace
- end
-
- def method_missing(m, *args)
- debug "named route: #{m}"
- current_parent << FakeRoute.new(args.shift, args.pop, m.to_s)
- end
-
- def self.indent
- ' ' * ((stack.length) * 2)
- end
-
- private
- def debug(txt)
- puts txt if ENV['DEBUG']
- end
-
- def stack(obj)
- self.class.stack << obj
- yield
- self.class.stack.pop
- end
-
- def current_parent
- self.class.stack.last
- end
- end
-
- class RouteObject
- def indent_lines(code_lines)
- if code_lines.length > 1
- code_lines.flatten.map {|l| "#{@indent}#{l.chomp}"}.join("\n") + "\n"
- else
- "#{@indent}#{code_lines.shift}"
- end
- end
-
- def opts_to_string(opts)
- opts.is_a?(Hash) ? opts.map {|k, v|
- ":#{k} => " + (v.is_a?(Hash) ? ('{ ' + opts_to_string(v) + ' }') : "#{value_to_string(v)}")
- }.join(", ") : opts.to_s
- end
-
- def value_to_string(value)
- case value
- when Regexp then value.inspect
- when String then "'" + value.to_s + "'"
- else value.to_s
- end
- end
- end
-
- class FakeNamespace < RouteObject
- attr_accessor :routes, :name
-
- def initialize(name)
- @routes = []
- @name = name
- @indent = RouteRedrawer.indent
- end
-
- def to_route_code
- lines = ["namespace :#{@name} do", @routes.map {|r| r.to_route_code}, "end"]
-
- indent_lines(lines)
- end
-
- def <<(val)
- @routes << val
- end
-
- def last
- @routes.last
- end
- end
-
- class FakeRoute < RouteObject
- attr_accessor :name, :path, :options
-
- def initialize(path, options, name = "")
- @path = path
- @options = options || {}
- @name = name
- @indent = RouteRedrawer.indent
- end
-
- def to_route_code
- if @options[:default_route]
- indent_lines ["match '#{@path}'"]
- else
- base = "match '%s' => '%s#%s'"
- extra_options = []
-
- if not name.empty?
- extra_options << ":as => :#{name}"
- end
-
- if @options[:requirements]
- @options[:constraints] = @options.delete(:requirements)
- end
-
- if @options[:conditions]
- @options[:via] = @options.delete(:conditions).delete(:method)
- end
-
- @options ||= {}
- base = (base % [@path, @options.delete(:controller), (@options.delete(:action) || "index")])
- opts = opts_to_string(@options)
-
- route_pieces = ([base] + extra_options + [opts])
- route_pieces.delete("")
-
- indent_lines [route_pieces.join(", ")]
- end
- end
- end
-
- class FakeResourceRoute < RouteObject
- attr_accessor :name, :children
-
- def initialize(name, options = {})
- @name = name
- @children = []
- @options = options
- @indent = RouteRedrawer.indent
- end
-
- def to_route_code
-
- if !@children.empty? || @options.has_key?(:collection) || @options.has_key?(:member)
- prefix = ["#{route_method} :#{@name} do"]
- lines = prefix + custom_methods + [@children.map {|r| r.to_route_code}.join("\n"), "end"]
-
- indent_lines(lines)
- else
- base = "#{route_method} :%s"
- indent_lines [base % [@name]]
- end
- end
-
- def custom_methods
- collection_code = generate_custom_methods_for(:collection)
- member_code = generate_custom_methods_for(:member)
- [collection_code, member_code]
- end
-
- def generate_custom_methods_for(group)
- return "" unless @options[group]
-
- method_code = []
-
- RouteRedrawer.stack << self
- @options[group].each do |k, v|
- method_code << "#{v} :#{k}"
- end
- RouteRedrawer.stack.pop
-
- indent_lines ["#{group} do", method_code, "end"].flatten
- end
-
- def route_method
- "resources"
- end
-
- def <<(val)
- @children << val
- end
-
- def last
- @children.last
- end
- end
-
- class FakeSingletonResourceRoute < FakeResourceRoute
- def route_method
- "resource"
- end
- end
-
- class RouteGenerator
- def initialize(routes)
- @routes = routes
- @new_code = ""
- end
-
- def generate
- @new_code = @routes.map do |r|
- r.to_route_code
- end.join("\n")
-
- "#{app_name.underscore.classify}::Application.routes.draw do\n#{@new_code}\nend\n"
- end
-
- private
- def app_name
- File.basename(Dir.pwd)
- end
- end
- end
-end
78 vendor/plugins/rails_upgrade/lib/tasks/rails_upgrade_tasks.rake
View
@@ -1,78 +0,0 @@
-$:.unshift(File.dirname(__FILE__) + "/../../lib")
-require 'routes_upgrader'
-require 'gemfile_generator'
-require 'application_checker'
-require 'new_configuration_generator'
-
-require 'fileutils'
-
-namespace :rails do
- namespace :upgrade do
- desc "Runs a battery of checks on your Rails 2.x app and generates a report on required upgrades for Rails 3"
- task :check do
- checker = Rails::Upgrading::ApplicationChecker.new
- checker.run
- end
-
- desc "Generates a Gemfile for your Rails 3 app out of your config.gem directives"
- task :gems do
- generator = Rails::Upgrading::GemfileGenerator.new
- new_gemfile = generator.generate_new_gemfile
-
- puts new_gemfile
- end
-
- desc "Create a new, upgraded route file from your current routes.rb"
- task :routes do
- upgrader = Rails::Upgrading::RoutesUpgrader.new
- new_routes = upgrader.generate_new_routes
-
- puts new_routes
- end
-
- desc "Extracts your configuration code so you can create a new config/application.rb"
- task :configuration do
- upgrader = Rails::Upgrading::NewConfigurationGenerator.new
- new_config = upgrader.generate_new_application_rb
-
- puts new_config
- end
-
- CLEAR = "\e[0m"
- CYAN = "\e[36m"
- WHITE = "\e[37m"
-
- desc "Backs up your likely modified files so you can run the Rails 3 generator on your app with little risk"
- task :backup do
- files = [".gitignore",
- "app/controllers/application_controller.rb",
- "app/helpers/application_helper.rb",
- "config/routes.rb",
- "config/environment.rb",
- "config/environments/development.rb",
- "config/environments/production.rb",
- "config/environments/staging.rb",
- "config/database.yml",
- "config.ru",
- "doc/README_FOR_APP",
- "test/test_helper.rb"]
-
- puts
- files.each do |f|
- if File.exist?(f)
- puts "#{CYAN}* #{CLEAR}backing up #{WHITE}#{f}#{CLEAR} to #{WHITE}#{f}.rails2#{CLEAR}"
- FileUtils.cp(f, "#{f}.rails2")
- end
- end
-
- puts
- puts "This is a list of the files analyzed and backed up (if they existed);\nyou will probably not want the generator to replace them since\nyou probably modified them (but now they're safe if you accidentally do!)."
- puts
-
- files.each do |f|
- puts "#{CYAN}- #{CLEAR}#{f}"
- end
- puts
- end
- end
-end
293 vendor/plugins/rails_upgrade/test/application_checker_test.rb
View
@@ -1,293 +0,0 @@
-require 'test_helper'
-require 'application_checker'
-require 'fileutils'
-
-tmp_dir = "#{File.dirname(__FILE__)}/fixtures/tmp"
-
-if defined? BASE_ROOT
- BASE_ROOT.replace tmp_dir
-else
- BASE_ROOT = tmp_dir
-end
-FileUtils.mkdir_p BASE_ROOT
-
-# Stub out methods on upgrader class
-module Rails
- module Upgrading
- class ApplicationChecker
- attr_reader :alerts
-
- def base_path
- BASE_ROOT + "/"
- end
-
- def in_rails_app?
- true
- end
-
- def initialize
- @alerts = {}
- end
-
- def alert(title, text, more_info_url, culprits)
- @alerts[title] = [text, more_info_url, culprits]
- end
- end
- end
-end
-
-class ApplicationCheckerTest < ActiveSupport::TestCase
- def setup
- @checker = Rails::Upgrading::ApplicationChecker.new
- @old_dir = Dir.pwd
-
- Dir.chdir(BASE_ROOT)
- end
-
- def test_check_ar_methods_in_controller
- make_file("app/controllers", "post_controller.rb", "Post.find(:all)")
- @checker.check_ar_methods
-
- assert @checker.alerts.has_key?("Soon-to-be-deprecated ActiveRecord calls")
- end
-
- def test_check_ar_methods_in_models
- make_file("app/models", "post.rb", "Post.find(:all)")
- @checker.check_ar_methods
-
- assert @checker.alerts.has_key?("Soon-to-be-deprecated ActiveRecord calls")
- end
-
- def test_check_validation_on_methods
- make_file("app/models", "post.rb", "validate_on_create :comments_valid?")
- @checker.check_validation_on_methods
-
- assert @checker.alerts.has_key?("Updated syntax for validate_on_* methods")
- end
-
- def test_check_before_validation_on_methods
- make_file("app/models", "post.rb", "before_validation_on_create :comments_valid?")
- @checker.check_before_validation_on_methods
-
- assert @checker.alerts.has_key?("Updated syntax for before_validation_on_* methods")
- end
-
- def test_named_scope_left_over
- make_file("app/models", "post.rb", "named_scope :failure")
- @checker.check_ar_methods
-
- assert @checker.alerts.has_key?("named_scope is now just scope")
- end
-
- def test_check_routes
- make_file("config/", "routes.rb", " map.connect 'fail'")
- @checker.check_routes
-
- assert @checker.alerts.has_key?("Old router API")
- end
-
- def test_check_for_old_test_help
- make_file("test/", "test_helper.rb", " require 'test_help'")
- @checker.check_test_help
-
- assert @checker.alerts.has_key?("Deprecated test_help path")
- end
-
- def test_check_for_old_test_help_with_double_quotes
- make_file("test/", "test_helper.rb", " require \"test_help\"")
- @checker.check_test_help
-
- assert @checker.alerts.has_key?("Deprecated test_help path")
- end
-
- def test_check_for_old_test_help_doesnt_see_test_helper
- make_file("test/", "test_helper.rb", " require 'test_helper'")
- @checker.check_test_help
-
- assert !@checker.alerts.has_key?("Deprecated test_help path")
- end
-
- def test_check_lack_of_app_dot_rb
- @checker.check_environment
-
- assert @checker.alerts.has_key?("New file needed: config/application.rb")
- end
-
- def test_check_environment_syntax
- make_file("config/", "environment.rb", "config.frameworks = []")
- @checker.check_environment
-
- assert @checker.alerts.has_key?("Old environment.rb")
- end
-
- def test_check_gems
- make_file("config/", "environment.rb", "config.gem 'rails'")
- @checker.check_gems
-
- assert @checker.alerts.has_key?("Old gem bundling (config.gems)")
- end
-
- def test_check_mailer_syntax
- make_file("app/models/", "notifications.rb", "def signup\nrecipients @users\n end")
- @checker.check_mailers
-
- assert @checker.alerts.has_key?("Old ActionMailer class API")
- end
-
- def test_check_mailer_syntax_from
- make_file("app/models/", "notifications.rb", "def signup\nfrom @user\n end")
- @checker.check_mailers
-
- assert @checker.alerts.has_key?("Old ActionMailer class API")
- end
-
- def test_check_mailer_syntax_subject
- make_file("app/models/", "notifications.rb", "def signup\nsubject @subject\n end")
- @checker.check_mailers
-
- assert @checker.alerts.has_key?("Old ActionMailer class API")
- end
-
- def test_check_mailer_syntax_attachment
- make_file("app/models/", "notifications.rb", "def signup\nattachment 'application/pdf' do |a|\n end")
- @checker.check_mailers
-
- assert @checker.alerts.has_key?("Old ActionMailer class API")
- end
-
- def test_new_check_mailer_syntax_from
- make_file("app/models/", "notifications.rb", "def signup\n:from => @users\n end")
- @checker.check_mailers
-
- assert ! @checker.alerts.has_key?("Old ActionMailer class API")
- end
-
- def test_new_check_mailer_syntax_subject
- make_file("app/models/", "notifications.rb", "def signup\n:subject => @users\n end")
- @checker.check_mailers
-
- assert ! @checker.alerts.has_key?("Old ActionMailer class API")
- end
-
- def test_new_check_mailer_syntax_attachments
- make_file("app/models/", "notifications.rb", "def signup\nattachments['an-image.jp'] = File.read('an-image.jpg')\n end")
- @checker.check_mailers
-
- assert ! @checker.alerts.has_key?("Old ActionMailer class API")
- end
-
- def test_check_mailer_api
- make_file("app/controllers/", "thing_controller.rb", "def signup\n Notifications.deliver_signup\n end")
- @checker.check_mailers
-
- assert @checker.alerts.has_key?("Deprecated ActionMailer API")
- end
-
- def test_check_generators
- make_file("vendor/plugins/thing/generators/thing/", "thing_generator.rb", "def manifest\n m.whatever\n end")
- @checker.check_generators
-
- assert @checker.alerts.has_key?("Old Rails generator API")
- end
-
- def test_check_plugins
- make_file("vendor/plugins/rspec-rails/", "whatever.rb", "def rspec; end")
- @checker.check_plugins
-
- assert @checker.alerts.has_key?("Known broken plugins")
- end
-
- def test_ignoring_comments
- make_file("config/", "routes.rb", "# map.connect 'fail'")
- @checker.check_routes
-
- assert !@checker.alerts.has_key?("Old router API")
- end
-
- def test_check_deprecated_constants_in_app_code
- make_file("app/controllers/", "thing_controller.rb", "class ThingController; THING = RAILS_ENV; end;")
- @checker.check_deprecated_constants
-
- assert @checker.alerts.has_key?("Deprecated constant(s)")
- end
-
- def test_check_deprecated_constants_in_lib
- make_file("lib/", "extra_thing.rb", "class ExtraThing; THING = RAILS_ENV; end;")
- @checker.check_deprecated_constants
-
- assert @checker.alerts.has_key?("Deprecated constant(s)")
- end
-
- def test_check_deprecated_cookie_settings
- make_file("config/initializers/", "more_settings.rb", "ActionController::Base.cookie_verifier_secret = 'OMG'")
- @checker.check_old_cookie_secret
-
- assert @checker.alerts.has_key?("Deprecated cookie secret setting")
- end
-
- def test_check_deprecated_session_secret
- make_file("config/initializers/", "more_settings.rb", "ActionController::Base.session = {\n:whatever => 'woot'\n}")
- @checker.check_old_session_secret
-
- assert @checker.alerts.has_key?("Deprecated session secret setting")
- end
-
- def test_check_deprecated_session_settings
- make_file("config/initializers/", "more_settings.rb", "ActionController::Base.session_store = :cookie\nthings.awesome(:whatever)")
- @checker.check_old_session_setting
-
- assert @checker.alerts.has_key?("Old session store setting")
- end
-
- def test_check_helpers
- make_file("app/views/users/", "test.html.erb", "<b>blah blah blah</b><% form_for(:thing) do |f| %> <label>doo dah</label> <%= f.whatever %> <% end %>")
- @checker.check_old_helpers
-
- assert @checker.alerts.has_key?("Deprecated ERb helper calls")
-
- end
-
- def test_check_old_helpers_lets_regular_blocks_pass
- make_file("app/views/users/", "another_test.html.erb", "<b>blah blah blah</b><% @some_items.each do |item| %> <label>doo dah</label> <%= item %> <% end %>")
- @checker.check_old_helpers
-
- assert_equal @checker.alerts.has_key?("Deprecated ERb helper calls"), false
- end
-
- def test_check_old_helpers_lets_regular_blocks_pass
- make_file("app/views/users/", "another_test.html.erb", "<b>blah blah blah</b><% @some_items.each do |item| %> <label>doo dah</label> <%= item %> <% end %>")
- @checker.check_old_helpers
-
- assert_equal @checker.alerts.has_key?("Deprecated ERb helper calls"), false
- end
-
- def test_check_old_ajax_helpers
- make_file("app/views/sections", "section.js", "<%= link_to_remote 'section-', :update => 'sections', :url => {:action => :destroy, :controller => 'sections', :id => @section.id } %>")
- @checker.check_old_ajax_helpers
-
- assert @checker.alerts.has_key?("Deprecated AJAX helper calls")
- end
-
- def test_check_old_ajax_helpers_empty
- @checker.check_old_ajax_helpers
-
- assert ! @checker.alerts.has_key?("Deprecated AJAX helper calls")
- end
-
- def teardown
- clear_files
-
- Dir.chdir(@old_dir)
- end
-
- def make_file(where, name=nil, contents=nil)
- FileUtils.mkdir_p "#{BASE_ROOT}/#{where}"
- File.open("#{BASE_ROOT}/#{where}/#{name}", "w+") do |f|
- f.write(contents)
- end if name
- end
-
- def clear_files
- FileUtils.rm_rf(Dir.glob("#{BASE_ROOT}/*"))
- end
-end
72 vendor/plugins/rails_upgrade/test/gemfile_generator_test.rb
View
@@ -1,72 +0,0 @@
-require 'test_helper'
-require 'gemfile_generator'
-
-# Stub out methods on upgrader class
-module Rails
- module Upgrading
- class GemfileGenerator
- attr_writer :environment_code
-
- def has_environment?
- true
- end
-
- def environment_code
- @environment_code
- end
- end
- end
-end
-
-class GemfileGeneratorTest < ActiveSupport::TestCase
- PREAMBLE = <<STR
-# Edit this Gemfile to bundle your application's dependencies.
-# This preamble is the current preamble for Rails 3 apps; edit as needed.
-source 'http://rubygems.org'
-
-gem 'rails', '3.0.0.beta3'
-
-STR
-
- def test_generates_with_no_gems
- generator = Rails::Upgrading::GemfileGenerator.new
- generator.environment_code = ""
-
- assert_equal PREAMBLE, generator.generate_gemfile
- end
-
- def test_generates_with_gem
- generator = Rails::Upgrading::GemfileGenerator.new
- generator.environment_code = "config.gem 'camping'"
-
- assert_equal PREAMBLE + "gem 'camping'", generator.generate_gemfile
- end
-
- def test_generates_with_version
- generator = Rails::Upgrading::GemfileGenerator.new
- generator.environment_code = "config.gem 'camping', :version => '2.1.1'"
-
- assert_equal PREAMBLE + "gem 'camping', '2.1.1'", generator.generate_gemfile
- end
-
- def test_can_add_sources
- generator = Rails::Upgrading::GemfileGenerator.new
- generator.environment_code = "config.gem 'camping', :source => 'http://code.whytheluckystiff.net'"
-
- assert_equal PREAMBLE + "source 'http://code.whytheluckystiff.net'\ngem 'camping'", generator.generate_gemfile
- end
-
- def test_changes_lib_to_new_key
- generator = Rails::Upgrading::GemfileGenerator.new
- generator.environment_code = "config.gem 'camping', :lib => 'kamping'"
-
- assert_equal PREAMBLE + "gem 'camping', :require => 'kamping'", generator.generate_gemfile
- end
-
- def test_generates_with_all_options
- generator = Rails::Upgrading::GemfileGenerator.new
- generator.environment_code = "config.gem 'camping', :lib => 'kamping', :source => 'http://code.whytheluckystiff.net', :version => '2.1.1'"
-
- assert_equal PREAMBLE + "source 'http://code.whytheluckystiff.net'\ngem 'camping', '2.1.1', :require => 'kamping'", generator.generate_gemfile
- end
-end
63 vendor/plugins/rails_upgrade/test/new_configuration_generator_test.rb
View
@@ -1,63 +0,0 @@
-require 'test_helper'
-require 'new_configuration_generator'
-
-# Stub out methods on upgrader class
-module Rails
- module Upgrading
- class NewConfigurationGenerator
- attr_writer :environment_code
-
- def has_environment?
- true
- end
-
- def environment_code
- @environment_code
- end
-
- def app_name
- "my_application"
- end
- end
- end
-end
-
-class NewConfigurationGeneratorTest < ActiveSupport::TestCase
- FRAME = "# Put this in config/application.rb
-require File.expand_path('../boot', __FILE__)
-
-module MyApplication
- class Application < Rails::Application
-%s
- end
-end"
-
- CONFIG = " config.what_have_you = 'thing'
- config.action_controller = 'what'"
-
- CODE = "require 'w/e'
-
-this_happens_before_the(code)
-more_before_the_code!
-
-Rails::Initializer.run do |config|
-%s
-end
-
-this_is_after_the_code
-"
-
- def test_raises_error_with_no_code
- generator = Rails::Upgrading::NewConfigurationGenerator.new
- generator.environment_code = ""
-
- assert_raises(RuntimeError) { generator.generate_new_application_rb }
- end
-
- def test_generates_with_code
- generator = Rails::Upgrading::NewConfigurationGenerator.new
- generator.environment_code = CODE % [CONFIG]
-
- assert_equal FRAME % [generator.indent(CONFIG)], generator.generate_new_application_rb
- end
-end
142 vendor/plugins/rails_upgrade/test/routes_upgrader_test.rb
View
@@ -1,142 +0,0 @@
-require 'test_helper'
-require 'routes_upgrader'
-
-# Stub out methods on upgrader class
-module Rails
- module Upgrading
- class RoutesUpgrader
- attr_writer :routes_code
-
- def has_routes_file?
- true
- end
-
- def routes_code
- @routes_code
- end
- end
-
- class RouteGenerator
- def app_name
- "MyApplication"
- end
- end
- end
-end
-
-class RoutesUpgraderTest < ActiveSupport::TestCase
- def setup
- Rails::Upgrading::RouteRedrawer.stack = []
- end
-
- def test_generates_routes_file
- routes_code = "
- ActionController::Routing::Routes.draw do |map|
- map.connect '/home', :controller => 'home', :action => 'index'
- map.login '/login', :controller => 'sessions', :action => 'new'
-
- map.resources :hats
- map.resource :store
- end
- "
-
- new_routes_code = "MyApplication::Application.routes.draw do
- match '/home' => 'home#index'
- match '/login' => 'sessions#new', :as => :login
- resources :hats
- resource :store
-end
-"
-
- upgrader = Rails::Upgrading::RoutesUpgrader.new
- upgrader.routes_code = routes_code
-
- result = upgrader.generate_new_routes
-
- assert_equal new_routes_code, result
- end
-
- def test_generates_code_for_regular_route
- route = Rails::Upgrading::FakeRoute.new("/about", {:controller => 'static', :action => 'about'})
- assert_equal "match '/about' => 'static#about'", route.to_route_code
- end
-
- def test_generates_code_for_named_route
- route = Rails::Upgrading::FakeRoute.new("/about", {:controller => 'static', :action => 'about'}, "about")
- assert_equal "match '/about' => 'static#about', :as => :about", route.to_route_code
- end
-
- def test_generates_code_for_namespace
- ns = Rails::Upgrading::FakeNamespace.new("static")
- # Add a route to the namespace
- ns << Rails::Upgrading::FakeRoute.new("/about", {:controller => 'static', :action => 'about'})
-
- assert_equal "namespace :static do\nmatch '/about' => 'static#about'\nend\n", ns.to_route_code
- end
-
- def test_generates_code_for_resources
- route = Rails::Upgrading::FakeResourceRoute.new("hats")
- assert_equal "resources :hats", route.to_route_code
- end
-
- def test_generates_code_for_resources
- route = Rails::Upgrading::FakeSingletonResourceRoute.new("hat")
- assert_equal "resource :hat", route.to_route_code
- end
-
- def test_generates_code_for_resources_with_special_methods
- route = Rails::Upgrading::FakeResourceRoute.new("hats", {:member => {:wear => :get}, :collection => {:toss => :post}})
- assert_equal "resources :hats do\ncollection do\npost :toss\nend\nmember do\nget :wear\nend\n\nend\n", route.to_route_code
- end
-
- def test_generates_code_for_route_with_extra_params
- route = Rails::Upgrading::FakeRoute.new("/about", {:controller => 'static', :action => 'about', :something => 'extra'})
- assert_equal "match '/about' => 'static#about', :something => 'extra'", route.to_route_code
- end
-
- def test_generates_code_for_route_with_requirements
- route = Rails::Upgrading::FakeRoute.new("/foo", {:controller => 'foo', :action => 'bar', :requirements => {:digit => /%d/}})
- assert_equal "match '/foo' => 'foo#bar', :constraints => { :digit => /%d/ }", route.to_route_code
- end
-
- def test_generates_code_for_root
- routes_code = "
- ActionController::Routing::Routes.draw do |map|
- map.root :controller => 'home', :action => 'index'
- end
- "
-
- new_routes_code = "MyApplication::Application.routes.draw do
- match '/' => 'home#index'
-end
-"
-
- upgrader = Rails::Upgrading::RoutesUpgrader.new
- upgrader.routes_code = routes_code
-
- result = upgrader.generate_new_routes
-
- assert_equal new_routes_code, result
- end
-
- def test_generates_code_for_default_route
- routes_code = "
- ActionController::Routing::Routes.draw do |map|
- map.connect ':controller/:action/:id.:format'
- map.connect ':controller/:action/:id'
- end
- "
-
- new_routes_code = "MyApplication::Application.routes.draw do
- match '/:controller(/:action(/:id))'
-end
-"
-
- upgrader = Rails::Upgrading::RoutesUpgrader.new
- upgrader.routes_code = routes_code
-
- result = upgrader.generate_new_routes
-
- assert_equal new_routes_code, result
- end
-end
5 vendor/plugins/rails_upgrade/test/test_helper.rb
View
@@ -1,5 +0,0 @@
-require 'test/unit'
-
-require 'rubygems'
-require 'active_support'
-require 'active_support/test_case'
1  vendor/plugins/rails_upgrade/uninstall.rb
View
@@ -1 +0,0 @@
-# Uninstall hook code here
Please sign in to comment.
Something went wrong with that request. Please try again.