New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Co-sponsored bills rank is incorrect #18

Open
itecedor opened this Issue Oct 19, 2013 · 4 comments

Comments

Projects
None yet
3 participants
@itecedor

itecedor commented Oct 19, 2013

Two examples where the rank is higher than the # of members:

screen shot 2013-10-19 at 2 52 42 pm
screen shot 2013-10-19 at 2 52 27 pm

@hypotext
@drinks

This comment has been minimized.

Show comment
Hide comment
@drinks

drinks Oct 19, 2013

Confirmed; the sponsored bill stats importer uses some dubious logic to determine who's in office. There's a sizeable deploy imminent that will address this and several other issues. Also, this repo will be moving, so stay tuned.

Ranks should be as below (though numbers pictured may lag by a couple of days), with the maximum being the highest rank in the body, not the number of members--there are a lot of ties so the high rank should almost always be lower than the total.

image

drinks commented Oct 19, 2013

Confirmed; the sponsored bill stats importer uses some dubious logic to determine who's in office. There's a sizeable deploy imminent that will address this and several other issues. Also, this repo will be moving, so stay tuned.

Ranks should be as below (though numbers pictured may lag by a couple of days), with the maximum being the highest rank in the body, not the number of members--there are a lot of ties so the high rank should almost always be lower than the total.

image

@itecedor

This comment has been minimized.

Show comment
Hide comment
@itecedor

itecedor Oct 21, 2013

@drinks thanks for replying. Just wanted to tell you that I found this while at an Open Hatch event on Saturday, and with @hypotext, we looked into fixing the logic ... until I read the announcement on the site that a whole new site is coming, so we figured it didn't make sense to fix the logic in the old site! We figured we'd leave the ticket open just so you guys would know about the bug. Can't wait to see the new site =)

itecedor commented Oct 21, 2013

@drinks thanks for replying. Just wanted to tell you that I found this while at an Open Hatch event on Saturday, and with @hypotext, we looked into fixing the logic ... until I read the announcement on the site that a whole new site is coming, so we figured it didn't make sense to fix the logic in the old site! We figured we'd leave the ticket open just so you guys would know about the bug. Can't wait to see the new site =)

@drinks

This comment has been minimized.

Show comment
Hide comment
@drinks

drinks Oct 31, 2013

Just wanted to follow up here that we've finished the switchover, and the new code is at https://github.com/sunlightlabs/opencongress. Definitely let us know there if you see any more data inconsistencies.

drinks commented Oct 31, 2013

Just wanted to follow up here that we've finished the switchover, and the new code is at https://github.com/sunlightlabs/opencongress. Definitely let us know there if you see any more data inconsistencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment