Skip to content

Conversation

@sudo-bmitch
Copy link
Contributor

This is following up on #1253 (review)

This is the result of running:

cd schema && go get github.com/opencontainers/image-spec@main

Which allows commands in schema to run without a go.work with a fixed version of the image-spec.

Signed-off-by: Brandon Mitchell <git@bmitch.net>
Copy link
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love it, but it seems fine.

@sudo-bmitch sudo-bmitch merged commit 2daaaaf into opencontainers:main Jul 24, 2025
5 checks passed
@sudo-bmitch sudo-bmitch deleted the pr-schema-go-mod branch July 24, 2025 17:58
@tianon
Copy link
Member

tianon commented Jul 24, 2025

We could also consider committing the go.work file: https://go.dev/ref/mod#:~:text=It%20is%20generally,and%20released%20properly.

That said, there are some cases where committing a go.work file makes sense. For example, when the modules in a repository are developed exclusively with each other but not together with external modules, there may not be a reason the developer would want to use a different combination of modules in a workspace. In that case, the module author should ensure the individual modules are tested and released properly.

@sudo-bmitch
Copy link
Contributor Author

We could also consider committing the go.work file

I'd consider it if we controlled all the workflows where the repo is used. But since we don't, the reasons not to checkin the file feel like they apply to us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants