Fix a typo and reference the RFC for defining standard DNS labels #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Bouzane <jbouzane@gmail.com>
| @@ -74,7 +74,7 @@ This specification uses the following terms: | |||
| A collection of tags grouped under a common prefix (the name component before <code>:</code>). | |||
| For example, in an image tagged with the name <code>my-app:3.1.4</code>, <code>my-app</code> is the <i>Repository</i> component of the name. | |||
| A repository name is made up of slash-separated name components, optionally prefixed by a DNS hostname. | |||
| The hostname must follow comply with standard DNS rules, but may not contain <code>_</code> characters. | |||
| The hostname must comply with standard DNS rules that apply to IDNA labels as defined in <a href="https://tools.ietf.org/html/rfc5890#section-2.3">RFC 5890</a>. | |||
There was a problem hiding this comment.
I still think we want to call out A-label, U-label, or NR-LDH label to avoid forbidding all-ASCII, non-A label, repository names.
|
Closing because we removed the "repository" language. |
|
This PR is invalidated by #223. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jason Bouzane jbouzane@gmail.com