image-layout: some schema #428

Merged
merged 1 commit into from Jan 12, 2017

Projects

None yet

5 participants

@vbatts
Member
vbatts commented Oct 31, 2016

Signed-off-by: Vincent Batts vbatts@hashbangbash.com

@wking
Contributor
wking commented Oct 31, 2016

On Mon, Oct 31, 2016 at 12:48:28PM -0700, Vincent Batts wrote:

A schema/image-layout.json (15)

I like this name, but the pattern so far has been to use *-schema.json
for these entry-point files 1. If we stick to that, this would be
image-layout-schema.json.

@jonboulle
Contributor

agree w/wking

schema/image-layout.json
+ "properties": {
+ "imageLayoutVersion": {
+ "description": "version of the OCI image-layout",
+ "type": "string"
@wking
wking Nov 2, 2016 Contributor

This should probably be an enum with 1.0.0 as the only option.

@vbatts
Member
vbatts commented Nov 3, 2016

PTAL

@wking
Contributor
wking commented Nov 3, 2016
@jonboulle
Contributor

is wanting rebase

@philips
Contributor
philips commented Nov 17, 2016

@vbatts needs rebase

@vbatts
Member
vbatts commented Nov 21, 2016

updated. PTAL.

@jonboulle
Contributor

there's no "MUST" here anymore

@vbatts
Member
vbatts commented Nov 22, 2016

@jonboulle you're right!

@vbatts vbatts changed the title from image-layout: a MUST and some schema to image-layout: some schema Nov 22, 2016
@vbatts
Member
vbatts commented Nov 22, 2016

updated. PTAL.

@jonboulle
Contributor
jonboulle commented Nov 22, 2016 edited

lgtm some

Approved with PullApprove

@wking
Contributor
wking commented Nov 22, 2016
@vbatts
Member
vbatts commented Nov 30, 2016

ugggggh. such rebase. Why does the schema fs have to include modtime?

updated.PTAL.

@vbatts
Member
vbatts commented Nov 30, 2016

.. omg ...
rebased. PTAL.

@jonboulle
Contributor

vincent

@jonboulle
Contributor
jonboulle commented Dec 1, 2016 edited

lgtm

Approved with PullApprove

@stevvooe
Contributor
stevvooe commented Dec 7, 2016 edited

LGTM

Approved with PullApprove

@jonboulle
Contributor

@vbatts lol

@vbatts vbatts image-layout: some schema
Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
694055e
@vbatts
Member
vbatts commented Dec 9, 2016

🤕
rebased. PTAL

@jonboulle
Contributor
jonboulle commented Dec 9, 2016 edited

lgtm

Approved with PullApprove

@vbatts
Member
vbatts commented Jan 11, 2017

bump

@stevvooe
Contributor
stevvooe commented Jan 12, 2017 edited

lgtm

Approved with PullApprove

@stevvooe stevvooe merged commit c88b4eb into opencontainers:master Jan 12, 2017

2 checks passed

code-review/pullapprove Approved by jonboulle, stevvooe
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment