Permalink
Commits on Aug 15, 2018
  1. merge branch 'pr-1867'

    cyphar committed Aug 15, 2018
      Revert "libcontainer/rootfs_linux: minor cleanup"
    
    LGTMs: @hqhq @cyphar
    Closes #1867
Commits on Aug 14, 2018
  1. Merge pull request #1864 from AkihiroSuda/update-criu

    mrunalp committed Aug 14, 2018
    Dockerfile: update criu to v3.10 + checkpoint-restore/criu@27034e7
  2. Revert "libcontainer/rootfs_linux: minor cleanup"

    mrunalp committed Aug 14, 2018
    This reverts commit 1b27db6.
    
    Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
Commits on Aug 12, 2018
  1. Dockerfile: update criu to v3.10 + checkpoint-restore/criu@27034e7

    AkihiroSuda committed Aug 10, 2018
    For criu v3.10, a patch is needed for `@test "checkpoint --lazy-pages and restore"`.
    Starting with v3.11, the patch will no longer be needed.
    
    The issue had not been caught in Travis because the kernel is too old and the test
    had not been executed in Travis.
    
    Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
Commits on Aug 1, 2018
  1. Merge pull request #1830 from crosbymichael/procs

    crosbymichael committed Aug 1, 2018
    Pass GOMAXPROCS to init processes
Commits on Jul 28, 2018
  1. Merge pull request #1841 from KentaTada/fix-makefile-modify-test-targ…

    dqminh committed Jul 28, 2018
    …et-option
    
    Fix the problem TESTFLAGS is not to be used in Makefile correctly
Commits on Jul 25, 2018
  1. Merge pull request #1845 from kinvolk/alban/mount-bind-fix1753

    crosbymichael committed Jul 25, 2018
    Fix regression with mounts with non-absolute source path
Commits on Jul 18, 2018
  1. Fix regression with mounts with non-absolute source path

    alban committed Jul 18, 2018
    PR #1753 introduced a test on the mount flags but the binary operator
    was wrong, see #1753 (comment)
    
    This was noticed when investigating opencontainers/runtime-tools#651
    
    Symptoms: in the container, /proc/self/mountinfo displays some mounts as
    follow:
    
    296 279 0:67 / /tmp rw,nosuid - tmpfs /home/dpark/go/src/github.com/opencontainers/runc/tmpfs rw,size=65536k,mode=755
    
    Signed-off-by: Alban Crequy <alban@kinvolk.io>
  2. Merge pull request #1840 from avagin/empty-ns-network

    hqhq committed Jul 18, 2018
    cr: don't dump network devices and their configuration
Commits on Jul 11, 2018
  1. Fix the problem TESTFLAGS is not to be used in Makefile correctly

    KentaTada committed Jul 11, 2018
    This commit modifies Makefile to handle test targets correctly.
    
    Signed-off-by: Kenta Tada <Kenta.Tada@sony.com>
  2. cr: don't dump network devices and their configuration

    avagin committed Jul 10, 2018
    RunC doesn't manage network devices and their configuration,
    so it is impossible to describe external dependencies to restore them
    back.
    
    This means that all users have to set --empty-ns network, so let's do
    this by default.
    
    Signed-off-by: Andrei Vagin <avagin@openvz.org>
Commits on Jul 10, 2018
  1. Merge pull request #1838 from adrianreber/lazy

    crosbymichael committed Jul 10, 2018
    criu tests: rename criu feature check
Commits on Jul 5, 2018
  1. merge branch 'pr-1836'

    cyphar committed Jul 5, 2018
      Add osusergo flag to static build
    
    LGTMs: @crosbymichael @cyphar
    Closes #1836
Commits on Jul 3, 2018
  1. criu tests: rename criu feature check

    adrianreber committed Jul 3, 2018
    Upstream renamed the feature check for lazy migration support from
    'lazy_pages' to 'uffd'. The lazy migration test case was therefore
    not running at all. This enables the lazy migration test case in runc
    again.
    
    The test will, however, not run in travis as the kernel is too old.
    But it works again locally.
    
    Signed-off-by: Adrian Reber <areber@redhat.com>
Commits on Jul 2, 2018
  1. Add osusergo flag to static build

    kolyshkin committed Jul 2, 2018
    This should fix the following (very legitimate) warnings on static
    build:
    
    > /tmp/go-link-818454663/000019.o: In function `mygetgrouplist':
    > /usr/lib/go-1.10/src/os/user/getgrouplist_unix.go:15: warning: Using
    > 'getgrouplist' in statically linked applications requires at runtime the
    > shared libraries from the glibc version used for linking
    >
    > /tmp/go-link-818454663/000018.o: In function `mygetgrgid_r':
    > /usr/lib/go-1.10/src/os/user/cgo_lookup_unix.go:38: warning: Using
    > 'getgrgid_r' in statically linked applications requires at runtime the
    > shared libraries from the glibc version used for linking
    >
    > ...
    
    as well as segfaults in the resulting binary.
    
    For more details, check golang/go#23265
    
    Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Commits on Jun 26, 2018
  1. Pass GOMAXPROCS to init processes

    crosbymichael committed Jun 26, 2018
    This will help runc's init to not spawn many threads on large systems when
    launched with max procs by the caller.
    
    Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
Commits on Jun 25, 2018
  1. Merge pull request #1824 from cyphar/fix-mips-build-devNumber

    crosbymichael committed Jun 25, 2018
    libcontainer: devices: fix mips builds
  2. Merge pull request #1820 from AkihiroSuda/crosscompile

    crosbymichael committed Jun 25, 2018
    travis: test cross compilation
  3. Merge pull request #1730 from deitch/document-terminal

    crosbymichael committed Jun 25, 2018
    Add docs for terminals
  4. Merge pull request #1827 from cyphar/domainname-sysctl-validator

    hqhq committed Jun 25, 2018
    libcontainer: improve "kernel.{domainname,hostname}" sysctl handling
Commits on Jun 24, 2018
  1. docs: add information about terminals

    cyphar and deitch committed Feb 22, 2018
    Users can get very confused by how terminals work with runc, and the
    quite confusing "terminal: ..." option. Add a document which goes
    through all of the important parts of terminal handling in runc, in the
    hopes that we can just point people to this as an explanation.
    
    Signed-off-by: Avi Deitcher <avi@deitcher.net>
    [cyphar: quite a large rewrite to fix factual errors and structure]
    Co-authored-by: Avi Deitcher <avi@deitcher.net>
    Signed-off-by: Aleksa Sarai <asarai@suse.de>
Commits on Jun 23, 2018
  1. Merge pull request #1825 from onlyjob/UNUSED

    dqminh committed Jun 23, 2018
    Stop using unix.SIGUNUSED which has been removed from golang.org/x/sys
Commits on Jun 18, 2018
  1. libcontainer: improve "kernel.{domainname,hostname}" sysctl handling

    cyphar committed Jun 18, 2018
    These sysctls are namespaced by CLONE_NEWUTS, and we need to use
    "kernel.domainname" if we want users to be able to set an NIS domainname
    on Linux. However we disallow "kernel.hostname" because it would
    conflict with the "hostname" field and cause confusion (but we include a
    helpful message to make it clearer to the user).
    
    Signed-off-by: Aleksa Sarai <asarai@suse.de>
Commits on Jun 17, 2018
  1. Stop using unix.SIGUNUSED which has been removed from golang.org/x/sys

    onlyjob committed Jun 17, 2018
    Bug-Debian: https://bugs.debian.org/889704
    
    Signed-off-by: Dmitry Smirnov <onlyjob@member.fsf.org>
  2. libcontainer: devices: fix mips builds

    cyphar committed Jun 17, 2018
    It turns out that MIPS uses uint32 in the device number returned by
    stat(2), so explicitly wrap everything to make the compiler happy. I
    really wish that Go had C-like numeric type promotion.
    
    Signed-off-by: Aleksa Sarai <asarai@suse.de>
Commits on Jun 16, 2018
  1. travis: test cross compilation

    AkihiroSuda committed Jun 16, 2018
    Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
Commits on Jun 15, 2018
  1. Merge pull request #1819 from tiborvass/fix-arm32bit

    mrunalp committed Jun 15, 2018
    libcontainer: fix compilation on GOARCH=arm GOARM=6 (32 bits)
  2. merge branch 'pr-1816'

    cyphar committed Jun 15, 2018
      runc: not require uid/gid mappings if euid()==0
    
    LGTMs: @mrunalp @cyphar
    Closes #1816
Commits on Jun 14, 2018
  1. libcontainer: fix compilation on GOARCH=arm GOARM=6 (32 bits)

    tiborvass committed Jun 14, 2018
    This fixes the following compilation error on 32bit ARM:
    ```
    $ GOARCH=arm GOARCH=6 go build ./libcontainer/system/
    libcontainer/system/linux.go:119:89: constant 4294967295 overflows int
    ```
    
    Signed-off-by: Tibor Vass <tibor@docker.com>
Commits on Jun 12, 2018
  1. runc: not require uid/gid mappings if euid()==0

    giuseppe committed Jun 12, 2018
    When running in a new unserNS as root, don't require a mapping to be
    present in the configuration file.  We are already skipping the test
    for a new userns to be present.
    
    Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Commits on Jun 4, 2018
  1. merge branch 'pr-1812'

    cyphar committed Jun 4, 2018
      Fix race in runc exec
    
    LGTMs: @dqminh @cyphar
    Closes #1812
Commits on Jun 2, 2018
  1. Merge pull request #1806 from cyphar/cgroup-ignorable-error-fixup

    dqminh committed Jun 2, 2018
    cgroup: clean up isIgnorableError for skippable EROFS
Commits on Jun 1, 2018
  1. Fix race in runc exec

    mrunalp committed Jun 1, 2018
    There is a race in runc exec when the init process stops just before
    the check for the container status. It is then wrongly assumed that
    we are trying to start an init process instead of an exec process.
    
    This commit add an Init field to libcontainer Process to distinguish
    between init and exec processes to prevent this race.
    
    Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
Commits on May 30, 2018
  1. Merge pull request #1808 from AkihiroSuda/fix-bad-merge

    crosbymichael committed May 30, 2018
    Fix merge conflict
  2. Fix merge conflict

    AkihiroSuda committed May 30, 2018
    Caused by:
    * #1688 0e56164
    * #1759 dd67ab1
    
    Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>