New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for r/o mount labels #1112

Merged
merged 1 commit into from Oct 17, 2016

Conversation

Projects
None yet
4 participants
@rhatdan
Contributor

rhatdan commented Oct 13, 2016

We need support for read/only mounts in SELinux to allow a bunch of
containers to share the same read/only image. In order to do this
we need a new label which allows container processes to read/execute
all files but not write them.

Existing mount label is either shared write or private write. This
label is shared read/execute.

Signed-off-by: Dan Walsh dwalsh@redhat.com

@rhatdan

This comment has been minimized.

Show comment
Hide comment
@rhatdan

rhatdan Oct 13, 2016

Contributor

This patch is needed for this pull request, and will probably be used by other golang programs in the future.

moby/moby#27364

Contributor

rhatdan commented Oct 13, 2016

This patch is needed for this pull request, and will probably be used by other golang programs in the future.

moby/moby#27364

@rhatdan

This comment has been minimized.

Show comment
Hide comment
@rhatdan

rhatdan Oct 13, 2016

Contributor

@rhvgoyal FYI

Contributor

rhatdan commented Oct 13, 2016

@rhvgoyal FYI

@rhatdan

This comment has been minimized.

Show comment
Hide comment
@rhatdan

rhatdan Oct 17, 2016

Contributor

avagin, caniszczyk, crosbymichael, cyphar, dqminh, hqhq, LK4D4, mrunalp, rjnagal, vmarmol PTAL

Contributor

rhatdan commented Oct 17, 2016

avagin, caniszczyk, crosbymichael, cyphar, dqminh, hqhq, LK4D4, mrunalp, rjnagal, vmarmol PTAL

@crosbymichael

This comment has been minimized.

Show comment
Hide comment
@crosbymichael

crosbymichael Oct 17, 2016

Member

can you rebase, there is a conflict.

Changes:

LGTM

Approved with PullApprove

Member

crosbymichael commented Oct 17, 2016

can you rebase, there is a conflict.

Changes:

LGTM

Approved with PullApprove

Add support for r/o mount labels
We need support for read/only mounts in SELinux to allow a bunch of
containers to share the same read/only image.  In order to do this
we need a new label which allows container processes to read/execute
all files but not write them.

Existing mount label is either shared write or private write.  This
label is shared read/execute.

Signed-off-by: Dan Walsh <dwalsh@redhat.com>
@rhatdan

This comment has been minimized.

Show comment
Hide comment
@rhatdan

rhatdan Oct 17, 2016

Contributor

Rebased.

Contributor

rhatdan commented Oct 17, 2016

Rebased.

@crosbymichael

This comment has been minimized.

Show comment
Hide comment
@crosbymichael
Member

crosbymichael commented Oct 17, 2016

LGTM

Approved with PullApprove

1 similar comment
@mrunalp

This comment has been minimized.

Show comment
Hide comment
@mrunalp

mrunalp Oct 17, 2016

Contributor

LGTM

Approved with PullApprove

Contributor

mrunalp commented Oct 17, 2016

LGTM

Approved with PullApprove

@mrunalp mrunalp merged commit 30a122d into opencontainers:master Oct 17, 2016

3 checks passed

code-review/pullapprove Approved by crosbymichael, mrunalp
Details
docker/dco-signed All commits signed
Details
janky Jenkins build runc-PRs 2388 has succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment