remove `-i` option to avoid failure of jenkins in non-interactive mode. #1252

Merged
merged 1 commit into from Jan 9, 2017

Projects

None yet

3 participants

@FengtuWang
Contributor

Signed-off-by: Fengtu Wang wangfengtu@huawei.com

@FengtuWang FengtuWang remove `-i` option to avoid failure of jenkins in non-interactive mode.
Signed-off-by: Fengtu Wang <wangfengtu@huawei.com>
b5d4da8
@FengtuWang
Contributor
FengtuWang commented Jan 4, 2017 edited

Use 'make test' in jenkins cause 'cannot enable tty mode on non tty input'. It seems that this option is not needed here.

@hqhq
Contributor
hqhq commented Jan 5, 2017

You should explain why Jenkins would cause this error. And why Jenkins in our upstream CI don't have this issue.

And please fix make shell as well.

@FengtuWang
Contributor

My jenkins can't run an interactive shell.So when i use 'make test' command in jenkins's shell, it print error message 'cannot enable tty mode on non tty input' as '-i' option can only used in an interactive environment. Jenkins in our upstream CI didn't have such problem because it didn't use 'make test' command in the shell. It use 'docker run' command directly instand, no option '-i' as well. Maybe someone's jenkins can resolve such problem by some plugins, but not mine. As this option seems no use, i'd like to remove it.

@FengtuWang
Contributor

I think we should keep '-i' option in 'make shell' command. This command seems to be designed for interactive situation, because it just start a container and enter bash. Other commands should be input manually.

@hqhq
Contributor
hqhq commented Jan 5, 2017 edited

LGTM

Approved with PullApprove

@crosbymichael
Member
crosbymichael commented Jan 9, 2017 edited

LGTM

Approved with PullApprove

@crosbymichael crosbymichael merged commit 54a4439 into opencontainers:master Jan 9, 2017

3 checks passed

code-review/pullapprove Approved by crosbymichael, hqhq
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
janky Jenkins build runc-PRs 2663 has succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment