New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore cgroup2 mountpoints #1266

Merged
merged 2 commits into from Jan 20, 2017

Conversation

Projects
None yet
4 participants
@mrunalp
Contributor

mrunalp commented Jan 10, 2017

Our current cgroup parsing logic assumes cgroup v1 mounts
so we should ignore cgroup2 mounts for now

Closes #1209

Signed-off-by: Mrunal Patel mrunalp@gmail.com

@mrunalp

This comment has been minimized.

Show comment
Hide comment
@mrunalp
Contributor

mrunalp commented Jan 10, 2017

@dqminh

This comment has been minimized.

Show comment
Hide comment
@dqminh

dqminh Jan 11, 2017

Contributor

can we add a testcase for this ?

Contributor

dqminh commented Jan 11, 2017

can we add a testcase for this ?

Ignore cgroup2 mountpoints
Our current cgroup parsing logic assumes cgroup v1 mounts
so we should ignore cgroup2 mounts for now

Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
@mrunalp

This comment has been minimized.

Show comment
Hide comment
@mrunalp

mrunalp Jan 11, 2017

Contributor

Sure, I'll add a test.

Contributor

mrunalp commented Jan 11, 2017

Sure, I'll add a test.

Add a test for testing that we ignore cgroup2 mounts
Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
@mrunalp

This comment has been minimized.

Show comment
Hide comment
@mrunalp

mrunalp Jan 12, 2017

Contributor

@dqminh Added a test.

Contributor

mrunalp commented Jan 12, 2017

@dqminh Added a test.

@hqhq

This comment has been minimized.

Show comment
Hide comment
@hqhq

hqhq Jan 17, 2017

Contributor

LGTM

Approved with PullApprove

Contributor

hqhq commented Jan 17, 2017

LGTM

Approved with PullApprove

@dqminh

This comment has been minimized.

Show comment
Hide comment
@dqminh

dqminh Jan 20, 2017

Contributor

LGTM

Approved with PullApprove

Contributor

dqminh commented Jan 20, 2017

LGTM

Approved with PullApprove

@dqminh dqminh merged commit b8cefd7 into opencontainers:master Jan 20, 2017

3 checks passed

code-review/pullapprove Approved by dqminh, hqhq
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
janky Jenkins build runc-PRs 2689 has succeeded
Details
@evverx

This comment has been minimized.

Show comment
Hide comment
@evverx

evverx Jan 23, 2017

@mrunalp , thanks. How does this PR affect #1175 ?

evverx commented Jan 23, 2017

@mrunalp , thanks. How does this PR affect #1175 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment