New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable integration test on arm64 platform #1642

Merged
merged 1 commit into from Dec 5, 2017

Conversation

Projects
None yet
7 participants
@lubinsz

lubinsz commented Nov 7, 2017

Currently, integration test can't be done on arm64 platform due to several issues.
Fix points:
1, add busybox.tar with arm64 format
2, add hello-world.tar with arm64 format

Signed-off-by: Bin Lu bin.lu@arm.com

@lubinsz

This comment has been minimized.

Show comment
Hide comment
@lubinsz

lubinsz Nov 7, 2017

@tianon @cyphar @avagin @dqminh
Hi all, can you help to check it?
Thanks.

lubinsz commented Nov 7, 2017

@tianon @cyphar @avagin @dqminh
Hi all, can you help to check it?
Thanks.

Show outdated Hide outdated Dockerfile Outdated
@lubinsz

This comment has been minimized.

Show comment
Hide comment
@lubinsz

lubinsz Nov 7, 2017

Hi @tianon ,
I have updated it. Using 'dpkg --print-architecture' now.
Thanks.

lubinsz commented Nov 7, 2017

Hi @tianon ,
I have updated it. Using 'dpkg --print-architecture' now.
Thanks.

@lubinsz

This comment has been minimized.

Show comment
Hide comment
@lubinsz

lubinsz commented Nov 10, 2017

@avagin
@caniszczyk
@crosbymichael
@cyphar
@dqminh
@hqhq
@mrunalp
@rjnagal
Hi all,
Could you take a look at it?
Thanks.

Show outdated Hide outdated tests/integration/helpers.bash Outdated
Show outdated Hide outdated tests/integration/helpers.bash Outdated
Show outdated Hide outdated Dockerfile Outdated
Show outdated Hide outdated tests/integration/helpers.bash Outdated
enable integration test on arm64 platform
Currently, integration test can't be done on arm64 platform due to several issues.
 Fix points:
 1, add busybox.tar with arm64 format
 2, add hello-world.tar with arm64 format

Signed-off-by: Bin Lu <bin.lu@arm.com>
@lubinsz

This comment has been minimized.

Show comment
Hide comment
@lubinsz

lubinsz Nov 14, 2017

@cyphar
Hi, what's your opinion?

lubinsz commented Nov 14, 2017

@cyphar
Hi, what's your opinion?

@lubinszARM

This comment has been minimized.

Show comment
Hide comment
@lubinszARM

lubinszARM Dec 5, 2017

Contributor

@avagin
@caniszczyk
@crosbymichael
@cyphar
@dqminh
@hqhq
@mrunalp
@rjnagal
Hi all,
We need to enable integration test in arm servers. So could you help to check it?
Thanks.

Contributor

lubinszARM commented Dec 5, 2017

@avagin
@caniszczyk
@crosbymichael
@cyphar
@dqminh
@hqhq
@mrunalp
@rjnagal
Hi all,
We need to enable integration test in arm servers. So could you help to check it?
Thanks.

@cyphar

This comment has been minimized.

Show comment
Hide comment
@cyphar

cyphar Dec 5, 2017

Member

LGTM.

Approved with PullApprove

Member

cyphar commented Dec 5, 2017

LGTM.

Approved with PullApprove

@crosbymichael

This comment has been minimized.

Show comment
Hide comment
@crosbymichael
Member

crosbymichael commented Dec 5, 2017

LGTM

Approved with PullApprove

@crosbymichael crosbymichael merged commit 1d3ab6d into opencontainers:master Dec 5, 2017

2 checks passed

code-review/pullapprove Approved by crosbymichael, cyphar
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment