New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import docker/docker/pkg/mount into runc #1644

Merged
merged 2 commits into from Nov 8, 2017

Conversation

Projects
None yet
3 participants
@vdemeester
Contributor

vdemeester commented Nov 8, 2017

This will help get rid of docker/docker dependency in runc 馃懠

With #1622 it should remove the docker/docker "cycle" dependency

/cc @jhowardmsft @crosbymichael @hqhq @mrunalp @cpuguy83 @dqminh @cyphar

(A follow could be to make `docker/docker use this package for those func instead of it's own impl.)

Signed-off-by: Vincent Demeester vincent@sbr.pm

@crosbymichael

This comment has been minimized.

Show comment
Hide comment
@crosbymichael

crosbymichael Nov 8, 2017

Member

needs a rebase

Member

crosbymichael commented Nov 8, 2017

needs a rebase

vdemeester added some commits Nov 8, 2017

Import docker/docker/pkg/mount into runc
This will help get rid of docker/docker dependency in runc 馃懠

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
Remove github.com/docker/docker from vendor
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@vdemeester

This comment has been minimized.

Show comment
Hide comment
@vdemeester

vdemeester Nov 8, 2017

Contributor

@crosbymichael rebased 馃懠

Contributor

vdemeester commented Nov 8, 2017

@crosbymichael rebased 馃懠

@crosbymichael

This comment has been minimized.

Show comment
Hide comment
@crosbymichael
Member

crosbymichael commented Nov 8, 2017

LGTM

Approved with PullApprove

1 similar comment
@dqminh

This comment has been minimized.

Show comment
Hide comment
@dqminh

dqminh Nov 8, 2017

Contributor

LGTM

Approved with PullApprove

Contributor

dqminh commented Nov 8, 2017

LGTM

Approved with PullApprove

@dqminh dqminh merged commit b2567b3 into opencontainers:master Nov 8, 2017

2 checks passed

code-review/pullapprove Approved by crosbymichael, dqminh
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@vdemeester vdemeester deleted the vdemeester:import-pkg-mount branch Nov 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment