New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove placeholder for non-linux platforms #1654

Merged
merged 2 commits into from Nov 30, 2017

Conversation

Projects
None yet
5 participants
@dqminh
Contributor

dqminh commented Nov 16, 2017

runc currently only support Linux platform, and since we dont intend to expose
the support to other platform, removing all other platforms placeholder code.

libcontainer/configs still being used in https://github.com/moby/moby/blob/master/daemon/daemon_windows.go so
keeping it for now.

cc @opencontainers/runc-maintainers @justincormack @jhowardmsft

@mrunalp

This comment has been minimized.

Show comment
Hide comment
@mrunalp

mrunalp Nov 17, 2017

Contributor

👍

Contributor

mrunalp commented Nov 17, 2017

👍

@dqminh dqminh changed the title from wip: remove placeholder for non-linux platforms to remove placeholder for non-linux platforms Nov 24, 2017

dqminh added some commits Nov 16, 2017

remove placeholder for non-linux platforms
runc currently only support Linux platform, and since we dont intend to expose
the support to other platform, removing all other platforms placeholder code.

`libcontainer/configs` still being used in
https://github.com/moby/moby/blob/master/daemon/daemon_windows.go so
keeping it for now.

After this, we probably should also rename files to drop linux suffices
if possible.

Signed-off-by: Daniel Dao <dqminh89@gmail.com>
vendor: removed more build=ignore vendor
Signed-off-by: Daniel Dao <dqminh89@gmail.com>
@dqminh

This comment has been minimized.

Show comment
Hide comment
@dqminh

dqminh Nov 24, 2017

Contributor

Rebased. I think this should be fine to look at.

I will send the rename of *_linux.go to *.go and a few general cleanup in another changeset.

Contributor

dqminh commented Nov 24, 2017

Rebased. I think this should be fine to look at.

I will send the rename of *_linux.go to *.go and a few general cleanup in another changeset.

@hqhq

This comment has been minimized.

Show comment
Hide comment
@hqhq

hqhq Nov 25, 2017

Contributor

LGTM

Approved with PullApprove

Contributor

hqhq commented Nov 25, 2017

LGTM

Approved with PullApprove

@gireeshpunathil

This comment has been minimized.

Show comment
Hide comment
@gireeshpunathil

gireeshpunathil Nov 25, 2017

@dqminh:

and since we dont intend to expose the support to other platform

Is this by policy / lack of contributor support / lack of infra / logistics or something else? can you please elaborate on this please?

I would like to see the feasibility of porting runc on AIX. I am interested and willing to contribute, if someone can provide little guidance. thanks!

gireeshpunathil commented Nov 25, 2017

@dqminh:

and since we dont intend to expose the support to other platform

Is this by policy / lack of contributor support / lack of infra / logistics or something else? can you please elaborate on this please?

I would like to see the feasibility of porting runc on AIX. I am interested and willing to contribute, if someone can provide little guidance. thanks!

@dqminh

This comment has been minimized.

Show comment
Hide comment
@dqminh

dqminh Nov 27, 2017

Contributor

Is this by policy / lack of contributor support / lack of infra / logistics

@gireeshpunathil From my POV its a little bit of everything. With majority of runc code only applicable to Linux, we think its easier for other platform implementations to being developed independently.

With runc being an implementation of OCI spec now https://github.com/opencontainers/runtime-spec, the first step for that would be to add AIX support for the OCI spec. https://groups.google.com/a/opencontainers.org/forum/#!forum/dev would be a good place i think, or may be @estesp also has some pointers 😄 !

Contributor

dqminh commented Nov 27, 2017

Is this by policy / lack of contributor support / lack of infra / logistics

@gireeshpunathil From my POV its a little bit of everything. With majority of runc code only applicable to Linux, we think its easier for other platform implementations to being developed independently.

With runc being an implementation of OCI spec now https://github.com/opencontainers/runtime-spec, the first step for that would be to add AIX support for the OCI spec. https://groups.google.com/a/opencontainers.org/forum/#!forum/dev would be a good place i think, or may be @estesp also has some pointers 😄 !

@gireeshpunathil

This comment has been minimized.

Show comment
Hide comment
@gireeshpunathil

gireeshpunathil Nov 27, 2017

thanks @dqminh , I will digest the linked docs and see how and where to start. Will look forward for your support an guidance!

gireeshpunathil commented Nov 27, 2017

thanks @dqminh , I will digest the linked docs and see how and where to start. Will look forward for your support an guidance!

dqminh added a commit to dqminh/moby that referenced this pull request Nov 27, 2017

remove import of opencontainers/runc in windows
We are planning to remove supports for non-Linux platform in
runc (opencontainers/runc#1654).  The current
import here is the only thing that i found in docker that is windows-related
so fixing this would remove the rest of windows code in runc.

This changes some functions in daemon_windows to be the same as
daemon_unix to use runtime-spec public API instead of runc.

Signed-off-by: Daniel Dao <dqminh89@gmail.com>
@dqminh

This comment has been minimized.

Show comment
Hide comment
@dqminh
Contributor

dqminh commented Nov 30, 2017

@crosbymichael

This comment has been minimized.

Show comment
Hide comment
@crosbymichael
Member

crosbymichael commented Nov 30, 2017

LGTM

Approved with PullApprove

@crosbymichael crosbymichael merged commit 91e9795 into opencontainers:master Nov 30, 2017

2 checks passed

code-review/pullapprove Approved by crosbymichael, hqhq
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

yongtang added a commit to yongtang/docker that referenced this pull request Dec 13, 2017

remove import of opencontainers/runc in windows
We are planning to remove supports for non-Linux platform in
runc (opencontainers/runc#1654).  The current
import here is the only thing that i found in docker that is windows-related
so fixing this would remove the rest of windows code in runc.

This changes some functions in daemon_windows to be the same as
daemon_unix to use runtime-spec public API instead of runc.

Signed-off-by: Daniel Dao <dqminh89@gmail.com>

docker-jenkins pushed a commit to docker/docker-ce that referenced this pull request Dec 14, 2017

remove import of opencontainers/runc in windows
We are planning to remove supports for non-Linux platform in
runc (opencontainers/runc#1654).  The current
import here is the only thing that i found in docker that is windows-related
so fixing this would remove the rest of windows code in runc.

This changes some functions in daemon_windows to be the same as
daemon_unix to use runtime-spec public API instead of runc.

Signed-off-by: Daniel Dao <dqminh89@gmail.com>
Upstream-commit: 4d1d486
Component: engine
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment