New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

man: Fix manpages related to console #1695

Merged
merged 1 commit into from Feb 8, 2018

Conversation

Projects
None yet
3 participants
@Taeung
Contributor

Taeung commented Jan 17, 2018

The commit 244c9fc ("*: console rewrite")
removed the --console option and the commit 7df64f8
("runc: implement --console-socket") create new option
--console-socket. However, the old --console option
still exists so fix it.

In addtion, add missing --preserve-fds option to
create and run manpages.

man: Fix manpages related to console
The commit 244c9fc ("*: console rewrite")
removed the --console option and the commit 7df64f8
("runc: implement --console-socket") create new option
--console-socket. However, the old --console option
still exists so fix it.

In addtion, add missing --preserve-fds option to
create and run manpages.

Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
Signed-off-by: charsyam <charsyam@naver.com>
@Taeung

This comment has been minimized.

Contributor

Taeung commented Jan 17, 2018

@cyphar , If you want to separate this commit into two commits(fixing --console and adding --preserve-fds), will do it. 😄

@Taeung

This comment has been minimized.

Contributor

Taeung commented Feb 8, 2018

Hi @cyphar @TomSweeneyRedHat @hqhq ,
I'd appreciate it, if you also check this PR 😸

@hqhq

This comment has been minimized.

Contributor

hqhq commented Feb 8, 2018

LGTM

Approved with PullApprove

1 similar comment
@crosbymichael

This comment has been minimized.

Member

crosbymichael commented Feb 8, 2018

LGTM

Approved with PullApprove

@crosbymichael crosbymichael merged commit a618ab5 into opencontainers:master Feb 8, 2018

2 checks passed

code-review/pullapprove Approved by crosbymichael, hqhq
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment