New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various cleanups to address linter issues #1911

Merged
merged 1 commit into from Nov 13, 2018

Conversation

Projects
None yet
3 participants
@theSuess
Contributor

theSuess commented Oct 13, 2018

Applied various fixes as recommended by golint (mostly redundant if)

Signed-off-by: Dominik Süß dominik@suess.wtf

various cleanups to address linter issues
Signed-off-by: Dominik Süß <dominik@suess.wtf>
@cyphar

This comment has been minimized.

Member

cyphar commented Nov 13, 2018

LGTM.

Approved with PullApprove

@cyphar

This comment has been minimized.

Member

cyphar commented Nov 13, 2018

Last call for pre-1.0 merges!
/cc @opencontainers/runc-maintainers

@cyphar cyphar added this to the 1.0.0 milestone Nov 13, 2018

@crosbymichael

This comment has been minimized.

Member

crosbymichael commented Nov 13, 2018

LGTM

Approved with PullApprove

@crosbymichael crosbymichael merged commit aa7917b into opencontainers:master Nov 13, 2018

2 checks passed

code-review/pullapprove Approved by crosbymichael, cyphar
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment