New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cgroups: nokmem: error out on explicitly-set kmemcg limits #1939

Merged
merged 1 commit into from Dec 4, 2018

Conversation

Projects
None yet
5 participants
@cyphar
Member

cyphar commented Nov 21, 2018

When built with nokmem we explicitly are disabling support for kmemcg,
but it is a strict specification requirement that if we cannot fulfil an
aspect of the container configuration that we error out.

Completely ignoring explicitly-requested kmemcg limits with nokmem would
undoubtably lead to problems.

Fixes #1938
Fixes: 6a2c155 ("libcontainer: ability to compile without kmem")
Signed-off-by: Aleksa Sarai asarai@suse.de

@cyphar cyphar added this to the 1.0.0 milestone Nov 21, 2018

@cyphar cyphar force-pushed the cyphar:nokmem-error branch from c4d8bd7 to b34c1d3 Nov 21, 2018

@cyphar cyphar changed the title from cgroups: error out if asked to explicitly set kmemcg limits under nokmem to cgroups: nokmem: error out on explicitly-set kmemcg limits Nov 21, 2018

@cyphar

This comment has been minimized.

Member

cyphar commented Nov 21, 2018

@kolyshkin

This comment has been minimized.

Contributor

kolyshkin commented Nov 29, 2018

LGTM except for a nitpick (s/fmt.Errorf/errors.New/)

@cyphar cyphar force-pushed the cyphar:nokmem-error branch from b34c1d3 to 496b3e6 Nov 29, 2018

@cyphar

This comment has been minimized.

Member

cyphar commented Nov 29, 2018

Fixed.

@crosbymichael

This comment has been minimized.

Member

crosbymichael commented Nov 29, 2018

LGTM

Approved with PullApprove

cgroups: nokmem: error out on explicitly-set kmemcg limits
When built with nokmem we explicitly are disabling support for kmemcg,
but it is a strict specification requirement that if we cannot fulfil an
aspect of the container configuration that we error out.

Completely ignoring explicitly-requested kmemcg limits with nokmem would
undoubtably lead to problems.

Fixes: 6a2c155 ("libcontainer: ability to compile without kmem")
Signed-off-by: Aleksa Sarai <asarai@suse.de>

@cyphar cyphar force-pushed the cyphar:nokmem-error branch from 496b3e6 to 8a4629f Dec 1, 2018

@mrunalp

This comment has been minimized.

Contributor

mrunalp commented Dec 4, 2018

LGTM

Approved with PullApprove

1 similar comment
@crosbymichael

This comment has been minimized.

Member

crosbymichael commented Dec 4, 2018

LGTM

Approved with PullApprove

@crosbymichael crosbymichael merged commit 25f3f89 into opencontainers:master Dec 4, 2018

2 checks passed

code-review/pullapprove Approved by crosbymichael, mrunalp
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cyphar cyphar deleted the cyphar:nokmem-error branch Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment