Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libcontainer: intelrdt: fix null intelrdt path issue in Destroy() #1955

Merged
merged 1 commit into from Feb 1, 2019
Merged

libcontainer: intelrdt: fix null intelrdt path issue in Destroy() #1955

merged 1 commit into from Feb 1, 2019

Commits on Jan 4, 2019

  1. libcontainer: intelrdt: fix null intelrdt path issue in Destroy() 

    This patch fixes a corner case when destroy a container:

If we start a container without 'intelRdt' config set, and then we run
“runc update --l3-cache-schema/--mem-bw-schema” to add 'intelRdt' config
implicitly.

Now if we enter "exit" from the container inside, we will pass through
linuxContainer.Destroy() -> state.destroy() -> intelRdtManager.Destroy().
But in IntelRdtManager.Destroy(), IntelRdtManager.Path is still null
string, it hasn’t been initialized yet. As a result, the created rdt
group directory during "runc update" will not be removed as expected.

Signed-off-by: Xiaochen Shen <xiaochen.shen@intel.com>
    @xiaochenshen
    xiaochenshen committed Jan 4, 2019
    Copy the full SHA
    acb75d0 View commit details
    Browse the repository at this point in the history