New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vendored golang.org/x/sys to latest #1972

Merged
merged 1 commit into from Feb 8, 2019

Conversation

Projects
None yet
3 participants
@filbranden
Copy link
Contributor

filbranden commented Feb 7, 2019

Update vendored repository from golang/sys@7ddbeae (September 2017) to golang/sys@41f3e65 (February 2019).

This will be needed for the unix.CGROUP_SUPER_MAGIC, unix.CGROUP2_SUPER_MAGIC and unix.TMPFS_MAGIC constants for the result of unix.Statfs(), which can be used to detect whether the system is running with cgroupv2 only.

Sending this as a separate PR to make it easy to review it, since the only change is to vendor.conf, the other files are only updated as a decorrence of running vndr with the update.

Update vendored golang.org/x/sys to latest
Signed-off-by: Filipe Brandenburger <filbranden@google.com>

@filbranden filbranden force-pushed the filbranden:vndr_unix1 branch from 6de1939 to 4a600c0 Feb 7, 2019

@crosbymichael

This comment has been minimized.

Copy link
Member

crosbymichael commented Feb 7, 2019

LGTM

Approved with PullApprove

@cyphar

This comment has been minimized.

Copy link
Member

cyphar commented Feb 8, 2019

LGTM. You don't need to submit this as a separate PR -- you could just include it as a separate commit in a single PR. I don't really mind either way, but it doesn't make it much easier (or harder) to review in either case.

Approved with PullApprove

@cyphar cyphar merged commit 4a600c0 into opencontainers:master Feb 8, 2019

2 checks passed

code-review/pullapprove Approved by crosbymichael, cyphar
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

cyphar added a commit that referenced this pull request Feb 8, 2019

merge branch 'pr-1972'
  Update vendored golang.org/x/sys to latest

LGTMs: @crosbymichael @cyphar
Closes #1972
@filbranden

This comment has been minimized.

Copy link
Contributor Author

filbranden commented Feb 8, 2019

Thanks!

I'm expecting the next ones will not be easy and will require some back and forth, so taking this out of the way in an easy PR means I'll have less trouble with rebases and merge conflicts etc... In any case, thanks for the prompt review and merge!

Cheers,
Filipe

@filbranden filbranden deleted the filbranden:vndr_unix1 branch Feb 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment