Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes regression causing zombie runc:[1:CHILD] processes #2023

Conversation

Projects
None yet
3 participants
@LittleLightLittleFire
Copy link
Contributor

LittleLightLittleFire commented Mar 21, 2019

Whenever processes are spawned using nsexec, a zombie runc:[1:CHILD]
process will always be created and will need to be reaped by the parent

Fixes #2022

@LittleLightLittleFire LittleLightLittleFire force-pushed the LittleLightLittleFire:2022-fix-runc-zombie-process-regression branch from 07b66b1 to 56e3f5d Mar 21, 2019

Fixes regression causing zombie runc:[1:CHILD] processes
Whenever processes are spawned using nsexec, a zombie runc:[1:CHILD]
process will always be created and will need to be reaped by the parent

Signed-off-by: Alex Fang <littlelightlittlefire@gmail.com>

@LittleLightLittleFire LittleLightLittleFire force-pushed the LittleLightLittleFire:2022-fix-runc-zombie-process-regression branch from 56e3f5d to eab5330 Mar 21, 2019

@cyphar

This comment has been minimized.

Copy link
Member

cyphar commented Mar 22, 2019

LGTM.

Approved with PullApprove

@crosbymichael

This comment has been minimized.

Copy link
Member

crosbymichael commented Mar 22, 2019

LGTM

Approved with PullApprove

@crosbymichael crosbymichael merged commit 11fc498 into opencontainers:master Mar 22, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

thaJeztah added a commit to thaJeztah/containerd that referenced this pull request Mar 28, 2019

update opencontainers/runc v1.0.0-rc7
full diff: opencontainers/runc@2b18fe1...v1.0.0-rc7

changes included:

- opencontainers/runc#2012 Need to setup labeling of kernel keyrings
- opencontainers/runc#2014 Add $RUNC_USE_SYSTEMD to run tests using systemd cgroup driver
- opencontainers/runc#2015 Use getenv not secure_getenv
  - fixes opencontainers/runc#2013 build fails with musl libc
- opencontainers/runc#2023 Fixes regression causing zombie runc:[1:CHILD] processes

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

thaJeztah added a commit to thaJeztah/containerd that referenced this pull request Mar 28, 2019

update opencontainers/runc v1.0.0-rc7
full diff: opencontainers/runc@2b18fe1...v1.0.0-rc7

changes included:

- opencontainers/runc#2012 Need to setup labeling of kernel keyrings
- opencontainers/runc#2014 Add $RUNC_USE_SYSTEMD to run tests using systemd cgroup driver
- opencontainers/runc#2015 Use getenv not secure_getenv
  - fixes opencontainers/runc#2013 build fails with musl libc
- opencontainers/runc#2023 Fixes regression causing zombie runc:[1:CHILD] processes

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit bc6ac08)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

thaJeztah added a commit to thaJeztah/containerd that referenced this pull request Mar 28, 2019

update opencontainers/runc v1.0.0-rc7
full diff: opencontainers/runc@2b18fe1...v1.0.0-rc7

changes included:

- opencontainers/runc#2012 Need to setup labeling of kernel keyrings
- opencontainers/runc#2014 Add $RUNC_USE_SYSTEMD to run tests using systemd cgroup driver
- opencontainers/runc#2015 Use getenv not secure_getenv
  - fixes opencontainers/runc#2013 build fails with musl libc
- opencontainers/runc#2023 Fixes regression causing zombie runc:[1:CHILD] processes

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit bc6ac08)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.