Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Go 1.12 and drop obsolete versions #2028

Merged
merged 1 commit into from Sep 5, 2019

Conversation

@thaJeztah
Copy link
Contributor

commented Mar 28, 2019

I noticed there's still a mention of Go 1.6 in the README;

https://github.com/opencontainers/runc/blob/master/README.md#building

It must be built with Go version 1.6 or higher in order for some features to function properly.

Not sure if we want to keep that mention, or if it's a bit redundant now that Go versions older than 1.6 reached EOL

@thaJeztah

This comment has been minimized.

Copy link
Contributor Author

commented Mar 28, 2019

Hm, interesting;

# time="2019-03-28T13:18:29Z" level=error msg="container_linux.go:345: starting container process caused \"process_linux.go:430: container init caused \\"write /proc/self/attr/keycreate: invalid argument\\"\"
@thaJeztah

This comment has been minimized.

Copy link
Contributor Author

commented Mar 28, 2019

looks like that's already failing on other PRs as well

Update to Go 1.12 and drop obsolete versions
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

@thaJeztah thaJeztah force-pushed the thaJeztah:bump_golang_versions branch from 19c5a0f to e7831f2 Apr 12, 2019

@thaJeztah

This comment has been minimized.

Copy link
Contributor Author

commented Apr 12, 2019

Rebased to trigger CI 😅

@thaJeztah

This comment has been minimized.

Copy link
Contributor Author

commented Apr 25, 2019

@crosbymichael

This comment has been minimized.

Copy link
Member

commented May 7, 2019

LGTM

Approved with PullApprove

@crosbymichael

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

LGTM

@AkihiroSuda

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2019

ping @cyphar

@thaJeztah

This comment has been minimized.

Copy link
Contributor Author

commented Jul 14, 2019

ping @cyphar PTAL 🤗

@AkihiroSuda

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2019

@mrunalp PTAL?

@kolyshkin
Copy link
Contributor

left a comment

LGTM (not a maintainer)

@mrunalp

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2019

LGTM

Approved with PullApprove

@mrunalp mrunalp merged commit 0fd4342 into opencontainers:master Sep 5, 2019

3 checks passed

DCO DCO
Details
code-review/pullapprove Approved by crosbymichael, mrunalp
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@thaJeztah thaJeztah deleted the thaJeztah:bump_golang_versions branch Sep 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.