Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main: not reopen /dev/stderr #2057

Merged
merged 1 commit into from May 15, 2019

Conversation

Projects
None yet
3 participants
@giuseppe
Copy link
Contributor

commented May 14, 2019

commit a146081 introduced a change to
write to /dev/stderr by default. Do not reopen the file in this case,
but use directly the fd 2.

Closes: #2056
Closes: kubernetes/kubernetes#77615
Closes: cri-o/cri-o#2368

Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com

main: not reopen /dev/stderr
commit a146081 introduced a change to
write to /dev/stderr by default.  Do not reopen the file in this case,
but use directly the fd 2.

Closes: #2056
Closes: kubernetes/kubernetes#77615
Closes: cri-o/cri-o#2368

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@cyphar

This comment has been minimized.

Copy link
Member

commented May 14, 2019

LGTM, though it's fairly silly that systemd makes /dev/stderr a socket (quite a few programs depend on /dev/stderr being a reasonable file).

Approved with PullApprove

@mrunalp

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

LGTM

Approved with PullApprove

@mrunalp mrunalp merged commit b9b6cc6 into opencontainers:master May 15, 2019

3 checks passed

DCO DCO
Details
code-review/pullapprove Approved by cyphar, mrunalp
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.