Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to define `COMMIT` by env #2071

Merged
merged 1 commit into from Jun 11, 2019

Conversation

Projects
None yet
3 participants
@judu
Copy link
Contributor

commented Jun 11, 2019

Some package managers download the archive instead of cloning the git repo.
When they do that, the call to git fails.

This commit allows package managers to provide the COMMIT value via environment.

Allow to define `COMMIT` by env
Some package managers download the archive instead of cloning the git repo.
When they do that, the call to git fails.

This commit allows package managers to provide the COMMIT value via environment.

Signed-off-by: Julien Durillon <julien.durillon@clever-cloud.com>

@judu judu force-pushed the judu:patch-1 branch from 8863a19 to 6770c86 Jun 11, 2019

@cyphar

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

LGTM I guess, though it should be noted that we use COMMIT_NO for this in openSUSE.

Approved with PullApprove

@crosbymichael

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

LGTM

Approved with PullApprove

@crosbymichael crosbymichael merged commit 6cc5158 into opencontainers:master Jun 11, 2019

3 checks passed

DCO DCO
Details
code-review/pullapprove Approved by crosbymichael, cyphar
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.