Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bash completion for v1.0.0 release #2075

Merged
merged 1 commit into from Jun 26, 2019

Conversation

Projects
None yet
3 participants
@KentaTada
Copy link
Contributor

commented Jun 26, 2019

I wanted to use this bash completion to complete new options like Intel RDT/MBA.
But I found that was not updated.
Could you review modification?

Signed-off-by: Kenta Tada Kenta.Tada@sony.com

Update bash completion for v1.0.0 release
Signed-off-by: Kenta Tada <Kenta.Tada@sony.com>
@cyphar

This comment has been minimized.

Copy link
Member

commented Jun 26, 2019

LGTM, seems reasonable.

Approved with PullApprove

@crosbymichael

This comment has been minimized.

Copy link
Member

commented Jun 26, 2019

LGTM

Approved with PullApprove

@crosbymichael crosbymichael merged commit 6cccc17 into opencontainers:master Jun 26, 2019

3 checks passed

DCO DCO
Details
code-review/pullapprove Approved by crosbymichael, cyphar
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.