Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cgroup: support mount of cgroup2 #2125

Merged
merged 1 commit into from Sep 11, 2019

Conversation

@giuseppe
Copy link
Contributor

commented Sep 6, 2019

convert a "cgroup" mount to "cgroup2" when the system uses cgroups v2
unified hierarchy.

Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com

@giuseppe

This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2019

@giuseppe

This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2019

tested with:

# podman run --cgroupns private -ti --rm --memory 100M fedora cat /sys/fs/cgroup/memory.max
104857600

# podman run -ti --rm --memory 100M fedora sh -c 'cat /sys/fs/cgroup/`sed -e "s|0::||g" /proc/self/cgroup`/memory.max'
104857600

@giuseppe giuseppe force-pushed the giuseppe:mount-cgroups branch from 0bf0cc9 to 3c22ec4 Sep 6, 2019

cgroup: support mount of cgroup2
convert a "cgroup" mount to "cgroup2" when the system uses cgroups v2
unified hierarchy.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>

@giuseppe giuseppe force-pushed the giuseppe:mount-cgroups branch from 3c22ec4 to 718a566 Sep 6, 2019

@crosbymichael

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

LGTM

Approved with PullApprove

1 similar comment
@mrunalp

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

LGTM

Approved with PullApprove

@mrunalp mrunalp merged commit 6c05552 into opencontainers:master Sep 11, 2019

3 checks passed

DCO DCO
Details
code-review/pullapprove Approved by crosbymichael, mrunalp
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.