Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VERSION: update to 1.0.0-rc9 #2134

Merged
merged 2 commits into from Oct 5, 2019

Conversation

@cyphar
Copy link
Member

commented Oct 1, 2019

Signed-off-by: Aleksa Sarai asarai@suse.de

cyphar added 2 commits Sep 30, 2019
Signed-off-by: Aleksa Sarai <asarai@suse.de>
Signed-off-by: Aleksa Sarai <asarai@suse.de>
@TomSweeneyRedHat

This comment has been minimized.

Copy link

commented Oct 1, 2019

LGTM

@crosbymichael

This comment has been minimized.

Copy link
Member

commented Oct 1, 2019

LGTM

Approved with PullApprove

Copy link
Contributor

left a comment

LGTM (not a maintainer)

@hqhq

This comment has been minimized.

Copy link
Contributor

commented Oct 5, 2019

LGTM

Approved with PullApprove

@cyphar

This comment has been minimized.

Copy link
Member Author

commented Oct 5, 2019

Still waiting for one of @dqminh or @mrunalp to make the 2/3rd requirement (which we definitely need to drop once we 1.0 -- this is getting a little bit silly).

@mrunalp

This comment has been minimized.

Copy link
Contributor

commented Oct 5, 2019

LGTM

Approved with PullApprove

@cyphar

This comment has been minimized.

Copy link
Member Author

commented Oct 5, 2019

Good enough for me. 😉

@mrunalp

This comment has been minimized.

Copy link
Contributor

commented Oct 5, 2019

@cyphar cyphar closed this in c1485a1 Oct 5, 2019
@cyphar cyphar merged commit 2111613 into opencontainers:master Oct 5, 2019
3 checks passed
3 checks passed
DCO DCO
Details
code-review/pullapprove Approved by crosbymichael, hqhq, mrunalp
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cyphar cyphar deleted the cyphar:release-rc9 branch Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.