Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the static_build build tag. #2154

Merged
merged 1 commit into from Nov 5, 2019

Conversation

@jpeach
Copy link
Contributor

jpeach commented Oct 25, 2019

The static_build build tag was introduced in e9944d0
to remove build warnings related to systemd cgroup driver
dependencies. Since then, those dependencies have changed and
building the systemd cgroup driver no longer imports dlopen.

After this change, runc builds will always include the systemd
cgroup driver.

This fixes #2008.

Signed-off-by: James Peach jpeach@apache.org

The `static_build` build tag was introduced in e9944d0
to remove build warnings related to systemd cgroup driver
dependencies. Since then, those dependencies have changed and
building the systemd cgroup driver no longer imports dlopen.

After this change, runc builds will always include the systemd
cgroup driver.

This fixes #2008.

Signed-off-by: James Peach <jpeach@apache.org>
@jpeach

This comment has been minimized.

Copy link
Contributor Author

jpeach commented Oct 25, 2019

/cc @cyphar since you merged #1579

@AkihiroSuda

This comment has been minimized.

Copy link
Contributor

AkihiroSuda commented Oct 29, 2019

@yongtang PTAL?

@crosbymichael

This comment has been minimized.

Copy link
Member

crosbymichael commented Oct 29, 2019

LGTM

Approved with PullApprove

@yongtang

This comment has been minimized.

Copy link
Contributor

yongtang commented Oct 29, 2019

LGTM

@mrunalp

This comment has been minimized.

Copy link
Contributor

mrunalp commented Nov 5, 2019

LGTM

Approved with PullApprove

@mrunalp mrunalp merged commit 46def4c into opencontainers:master Nov 5, 2019
3 checks passed
3 checks passed
DCO DCO
Details
code-review/pullapprove Approved by crosbymichael, mrunalp
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.