Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make event types public #2172

Merged
merged 1 commit into from Dec 2, 2019
Merged

Make event types public #2172

merged 1 commit into from Dec 2, 2019

Conversation

@saschagrunert
Copy link
Contributor

saschagrunert commented Nov 26, 2019

The event types are now part of a dedicated public types package
within runc to be able to unmarshal the output runc events directly.

cc @mrunalp @cyphar

The event types are now part of a dedicated public `types` package
within runc to be able to unmarshal the output `runc events` directly.

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@cyphar

This comment has been minimized.

Copy link
Member

cyphar commented Nov 26, 2019

Tentative LGTM, though I'm not sure if @crosbymichael has a strong opinion on where such API stuff should go. But I agree that this is something we should expose to avoid duplication in runc users.

@crosbymichael

This comment has been minimized.

Copy link
Member

crosbymichael commented Dec 2, 2019

LGTM

Approved with PullApprove

@cyphar

This comment has been minimized.

Copy link
Member

cyphar commented Dec 2, 2019

LGTM.

Approved with PullApprove

@cyphar cyphar merged commit 42690e6 into opencontainers:master Dec 2, 2019
3 checks passed
3 checks passed
DCO DCO
Details
code-review/pullapprove Approved by crosbymichael, cyphar
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@saschagrunert saschagrunert deleted the openSUSE:events branch Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.