Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temporarily disable CRIU tests #2198

Merged
merged 2 commits into from Jan 14, 2020
Merged

Conversation

@AkihiroSuda
Copy link
Contributor

AkihiroSuda commented Jan 1, 2020

update criu to the latest revision on criu-dev branch (v3.13 is not enough to fix the issue)

Fix #2196

EDIT: Changed PR to skip the tests until Ubuntu kernel gets fixed (#2198 (comment))

contains #2206

@crosbymichael

This comment has been minimized.

Copy link
Member

crosbymichael commented Jan 2, 2020

now it's worse :)

@AkihiroSuda AkihiroSuda force-pushed the AkihiroSuda:criu-master branch from 2044eb1 to 43591ce Jan 6, 2020
@AkihiroSuda AkihiroSuda changed the title Dockerfile: update criu (Dec 28, 2019 master) Dockerfile: update criu (Jan 4, 2019) Jan 6, 2020
@AkihiroSuda

This comment has been minimized.

Copy link
Contributor Author

AkihiroSuda commented Jan 6, 2020

@adrianreber Is this planned to be fixed soon? Should we skip CRIU tests?

@adrianreber

This comment has been minimized.

Copy link
Contributor

adrianreber commented Jan 6, 2020

I was not aware of this. As this seems to be Travis related I guess this could be:

https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1857257

With updated Ubuntu kernels with have also seen CRIU errors. So far this seems to be Ubuntu only.

@adrianreber

This comment has been minimized.

Copy link
Contributor

adrianreber commented Jan 6, 2020

Is this planned to be fixed soon?

As this seems to be right now a Ubuntu only problem, I have no real idea. We switched to using docker with graphdriver devicemapper or Podman with graphdriver vfs.

Should we skip CRIU tests?

I really do not want to say to skip CRIU tests, but maybe that is necessary if above workarounds are not a solution for you. Maybe adding a comment to the Ubuntu bug would help to highlight this problem.

AkihiroSuda added a commit to AkihiroSuda/runc that referenced this pull request Jan 7, 2020
Ubuntu kernel is temporarily broken: opencontainers#2198 (comment)

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda force-pushed the AkihiroSuda:criu-master branch from 43591ce to e93cf73 Jan 7, 2020
@AkihiroSuda AkihiroSuda changed the title Dockerfile: update criu (Jan 4, 2019) temporarily disable CRIU tests Jan 7, 2020
@AkihiroSuda

This comment has been minimized.

Copy link
Contributor Author

AkihiroSuda commented Jan 7, 2020

Changed PR to skip the tests until Ubuntu kernel gets fixed

@crosbymichael

This comment has been minimized.

Copy link
Member

crosbymichael commented Jan 7, 2020

LGTM

Approved with PullApprove

AkihiroSuda added a commit to AkihiroSuda/runc that referenced this pull request Jan 14, 2020
Ubuntu kernel is temporarily broken: opencontainers#2198 (comment)

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda force-pushed the AkihiroSuda:criu-master branch from e93cf73 to 6d6e922 Jan 14, 2020
AkihiroSuda added 2 commits Jan 14, 2020
A new method was added to the cgroup interface when #2177 was merged.

After #2177 got merged, #2169 was merged without rebase (sorry!) and compilation was failing:

  libcontainer/cgroups/fs2/fs2.go:208:22: container.Cgroup undefined (type *configs.Config has no field or method Cgroup)

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Ubuntu kernel is temporarily broken: #2198 (comment)

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda force-pushed the AkihiroSuda:criu-master branch from 6d6e922 to 55f8c25 Jan 14, 2020
@AkihiroSuda

This comment has been minimized.

Copy link
Contributor Author

AkihiroSuda commented Jan 14, 2020

Rebased and green. Now contains #2206

@AkihiroSuda

This comment has been minimized.

Copy link
Contributor Author

AkihiroSuda commented Jan 14, 2020

@cyphar

This comment has been minimized.

Copy link
Member

cyphar commented Jan 14, 2020

Ah, I'll close #2206 since it's really hard to track which PRs contain each other...

@cyphar

This comment has been minimized.

Copy link
Member

cyphar commented Jan 14, 2020

LGTM, but please open a tracking bug to re-enable the CRIU tests.

Approved with PullApprove

@AkihiroSuda

This comment has been minimized.

Copy link
Contributor Author

AkihiroSuda commented Jan 14, 2020

tracking issue: #2208

@AkihiroSuda

This comment has been minimized.

Copy link
Contributor Author

AkihiroSuda commented Jan 14, 2020

merge?

@hqhq

This comment has been minimized.

Copy link
Contributor

hqhq commented Jan 14, 2020

LGTM

Approved with PullApprove

@hqhq hqhq merged commit 709377c into opencontainers:master Jan 14, 2020
3 checks passed
3 checks passed
DCO DCO
Details
code-review/pullapprove Approved by cyphar, hqhq
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.