Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Systemd name #315

Merged
merged 2 commits into from Oct 5, 2015
Merged

Systemd name #315

merged 2 commits into from Oct 5, 2015

Conversation

mrunalp
Copy link
Contributor

@mrunalp mrunalp commented Oct 5, 2015

This fixes moby/moby#16775

docker exec doesn't set the name cgroup for systemd correctly. This PR introduces a name cgroup that is used only in GetPaths so docker exec gets all the paths that are passed down to EnterPid.

Signed-off-by: Mrunal Patel mrunalp@gmail.com

This is meant to be used in retrieving the paths so an exec
process enters all the cgroup paths correctly.

Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
This allows getting the path to the subsystem and so is subsequently
used in EnterPid by an exec process.

Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
@mrunalp
Copy link
Contributor Author

mrunalp commented Oct 5, 2015

@LK4D4 @crosbymichael ping

@crosbymichael
Copy link
Member

LGTM

1 similar comment
@LK4D4
Copy link
Contributor

LK4D4 commented Oct 5, 2015

LGTM

LK4D4 added a commit that referenced this pull request Oct 5, 2015
@LK4D4 LK4D4 merged commit d7ce356 into opencontainers:master Oct 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

name cgroup doesn't match in docker exec when using systemd
4 participants