Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.1] configs/validate: looser validation for RDT #3406

Merged
merged 1 commit into from Mar 14, 2022

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Mar 8, 2022

Backport of #3382.


Don't require CAT or MBA because we don't detect those correctly (we
don't support L2 or L3DATA/L3CODE for example, and in the future
possibly even more). With plain "ClosId mode" we don't really care: we
assign the container to a pre-configured CLOS without trying to do
anything smarter.

Moreover, this was a duplicate/redundant check anyway, as for CAT and
MBA there is another specific sanity check that is done if L3 or MB
is specified in the config.

Signed-off-by: Markus Lehtonen markus.lehtonen@intel.com
(cherry picked from commit 1d5c331)

@marquiz
Copy link
Contributor Author

marquiz commented Mar 8, 2022

@kolyshkin @AkihiroSuda please take a look

AkihiroSuda
AkihiroSuda previously approved these changes Mar 8, 2022
@AkihiroSuda AkihiroSuda added this to the 1.1.1 milestone Mar 8, 2022
dqminh
dqminh previously approved these changes Mar 8, 2022
@kolyshkin kolyshkin added area/intelrdt backport/1.1-pr A backport to 1.1.x release. labels Mar 8, 2022
@kolyshkin
Copy link
Contributor

kolyshkin commented Mar 8, 2022

I'm going to try to use github feature to rebase this. If this will work, I'll enable this feature for the main branch as well.

@kolyshkin kolyshkin dismissed stale reviews from dqminh and AkihiroSuda via 4316e83 Mar 8, 2022
@kolyshkin
Copy link
Contributor

kolyshkin commented Mar 8, 2022

Alas, the feature is not working the way I hoped for (git pull --rebase && git push -f). Fixed manually.

kolyshkin
kolyshkin previously approved these changes Mar 8, 2022
Copy link
Contributor

@kolyshkin kolyshkin left a comment

LGTM

@kolyshkin
Copy link
Contributor

kolyshkin commented Mar 8, 2022

@dqminh @AkihiroSuda you have to re-LGTM; my apologies.

@kolyshkin kolyshkin requested review from dqminh and AkihiroSuda Mar 8, 2022
AkihiroSuda
AkihiroSuda previously approved these changes Mar 9, 2022
@AkihiroSuda
Copy link
Member

AkihiroSuda commented Mar 9, 2022

marquiz authored and kolyshkin committed 8 hours ago

@kolyshkin I guess we need your Signed-off-by line too

@kolyshkin kolyshkin dismissed stale reviews from AkihiroSuda and themself via 094e402 Mar 10, 2022
@kolyshkin kolyshkin requested review from kolyshkin and AkihiroSuda Mar 10, 2022
@kolyshkin
Copy link
Contributor

kolyshkin commented Mar 10, 2022

@kolyshkin I guess we need your Signed-off-by line too

Added.

Copy link
Contributor

@kolyshkin kolyshkin left a comment

LGTM

Don't require CAT or MBA because we don't detect those correctly (we
don't support L2 or L3DATA/L3CODE for example, and in the future
possibly even more). With plain "ClosId mode" we don't really care: we
assign the container to a pre-configured CLOS without trying to do
anything smarter.

Moreover, this was a duplicate/redundant check anyway, as for CAT and
MBA there is another specific sanity check that is done if L3 or MB
is specified in the config.

Signed-off-by: Markus Lehtonen <markus.lehtonen@intel.com>
(cherry picked from commit 1d5c331)
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin kolyshkin merged commit 6f48ab3 into opencontainers:release-1.1 Mar 14, 2022
24 checks passed
@kolyshkin kolyshkin mentioned this pull request Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/intelrdt backport/1.1-pr A backport to 1.1.x release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants