features: implement returning potentiallyUnsafeConfigAnnotations list #4217
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://github.com/opencontainers/runtime-spec/blob/v1.2.0/features.md#unsafe-annotations-in-configjson Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
cyphar
approved these changes
Mar 11, 2024
| @@ -64,6 +64,11 @@ var featuresCommand = cli.Command{ | |||
| }, | |||
| }, | |||
| }, | |||
| PotentiallyUnsafeConfigAnnotations: []string{ | |||
| "bundle", | |||
There was a problem hiding this comment.
I totally forgot about this internal annotation. We should probably see if we can remove it...
(I suspect we also always override it, so it's technically not unsafe but it's better to be safe than sorry.)
|
ping @opencontainers/runc-maintainers |
lifubang
approved these changes
Mar 25, 2024
|
Could this fix get backported to 1.1.x so security minded users aren't force to use a release candidate? |
|
For runc v1.1 we do not plan to bump up the spec version, so I'd suggest to use a hard-coded list |
|
Linking: This PR is misunderstood to fix the GHSA, but it actually does not, as the vuln is not on runc side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/opencontainers/runtime-spec/blob/v1.2.0/features.md#unsafe-annotations-in-configjson