Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
cgroup: add PIDs cgroup controller support #446
This is a fixed up version of the now-reverted #58. The main issue with that code was that some of the memory cgroup's limits weren't being set at all if you were using systemd. Unfortunately, I seem to be unable to test the systemd portion (and the systemd test cases for memory don't actually test that the limits cause a process to fail).
All other cgroups were unaffected by this bug (as their limits were set using
Some testing has revealed that the old setup didn't work either (because
changed the title from
Add PIDs cgroup controller support
cgroupAdd PIDs cgroup controller support
Dec 20, 2015
@mrunalp The main change I made to #58 was to actually explicitly
It should be noted that the "fix" for getting systemd to "work" is to just use the fs driver for basically everything. Unfortunately, there's deeper systemd issues here. At least it all works now.
@cyphar No I don't get any errors when setting
BTW, I don't have a box with latest kernel to test this PR out, but over all the codes in this PR looks good, if there are any systemd issues with docker, I can help diagnose.
@hqhq I'm testing this on Arch (with a custom-compiled kernel). The systemd problems I'm referring to are not related to this PR (there are a few). I'll open a separate issue (or PR) for these problems if appropriate (a SUSE customer has seen issues with systemd on SLE).
Due to some upstream kernel changes introduced in
Ultimately, we do the best we can. Anything else is either due to the fact we use Go (which isn't going to change soon) or are potential kernel bugs (gulp).
NOTE: This doesn't actually affect the driver code, just the tests.