New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to non-recursive GetPids, add recursive GetAllPids #463

Merged
merged 1 commit into from Jan 8, 2016

Conversation

Projects
None yet
6 participants
@jimmidyson
Contributor

jimmidyson commented Jan 8, 2016

Fixes #457

/cc @LK4D4 @vishh

Revert to non-recursive GetPids, add recursive GetAllPids
Signed-off-by: Jimmi Dyson <jimmidyson@gmail.com>

@GordonTheTurtle GordonTheTurtle removed the dco/no label Jan 8, 2016

@jimmidyson

This comment has been minimized.

Show comment
Hide comment
@jimmidyson

jimmidyson Jan 8, 2016

Contributor

Would appreciate fairly quick review if possible @LK4D4 @vishh so I can get this pulled in to Kubernetes if accepted.

Contributor

jimmidyson commented Jan 8, 2016

Would appreciate fairly quick review if possible @LK4D4 @vishh so I can get this pulled in to Kubernetes if accepted.

@vishh

This comment has been minimized.

Show comment
Hide comment
@vishh

vishh Jan 8, 2016

Contributor

LGTM. Thanks @jimmidyson!

Contributor

vishh commented Jan 8, 2016

LGTM. Thanks @jimmidyson!

@mrunalp

This comment has been minimized.

Show comment
Hide comment
@mrunalp

mrunalp Jan 8, 2016

Contributor

I've restarted the build.

Contributor

mrunalp commented Jan 8, 2016

I've restarted the build.

@mrunalp

This comment has been minimized.

Show comment
Hide comment
@mrunalp

mrunalp Jan 8, 2016

Contributor

@jfrazelle There is some issue with the builds. Could you please take a look? Thanks!

Contributor

mrunalp commented Jan 8, 2016

@jfrazelle There is some issue with the builds. Could you please take a look? Thanks!

@mrunalp

This comment has been minimized.

Show comment
Hide comment
@mrunalp

mrunalp Jan 8, 2016

Contributor

nvm, this just turned green :)

Contributor

mrunalp commented Jan 8, 2016

nvm, this just turned green :)

@LK4D4

This comment has been minimized.

Show comment
Hide comment
@LK4D4

LK4D4 Jan 8, 2016

Contributor

LGTM

Contributor

LK4D4 commented Jan 8, 2016

LGTM

LK4D4 added a commit that referenced this pull request Jan 8, 2016

Merge pull request #463 from jimmidyson/non-recursive-pids
Revert to non-recursive GetPids, add recursive GetAllPids

@LK4D4 LK4D4 merged commit 910752f into opencontainers:master Jan 8, 2016

2 checks passed

docker/dco-signed All commits signed
Details
janky Jenkins build runc-PRs 901 has succeeded
Details
@jimmidyson

This comment has been minimized.

Show comment
Hide comment
@jimmidyson

jimmidyson Jan 8, 2016

Contributor

Thanks! Any chance of a tag?

Contributor

jimmidyson commented Jan 8, 2016

Thanks! Any chance of a tag?

@LK4D4

This comment has been minimized.

Show comment
Hide comment
@LK4D4

LK4D4 Jan 9, 2016

Contributor

@jimmidyson I want to merge pids cgroup before tagging.

Contributor

LK4D4 commented Jan 9, 2016

@jimmidyson I want to merge pids cgroup before tagging.

@jimmidyson

This comment has been minimized.

Show comment
Hide comment
@jimmidyson

jimmidyson Jan 11, 2016

Contributor

@LK4D4 Is there a PR for that that I can track?

Contributor

jimmidyson commented Jan 11, 2016

@LK4D4 Is there a PR for that that I can track?

@jimmidyson

This comment has been minimized.

Show comment
Hide comment
@jimmidyson
Contributor

jimmidyson commented Jan 11, 2016

#446?

@cyphar

This comment has been minimized.

Show comment
Hide comment
@cyphar
Member

cyphar commented Jan 11, 2016

stefanberger pushed a commit to stefanberger/runc that referenced this pull request Sep 8, 2017

Merge pull request #463 from wking/no-create-api-caveat
runtime: Drop create-specific API caveat from lifecycle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment