Permalink
Commits on Jan 13, 2017
  1. Merge pull request #653 from mrunalp/remove_str_ptrs

    Remove string pointers
    hqhq committed on GitHub Jan 13, 2017
Commits on Jan 12, 2017
  1. Merge pull request #652 from Mashimiao/defs-add-missing-int64-pointer

    defs.json: add misssing int64Pointer
    crosbymichael committed on GitHub Jan 12, 2017
  2. Remove string pointers

    Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
    mrunalp committed Jan 12, 2017
  3. Merge pull request #645 from Mashimiao/config-add-key-empty-limit

    config.md: add empty limit for key of annotations
    mrunalp committed on GitHub Jan 12, 2017
  4. Merge pull request #647 from Mashimiao/config-linux-fix-device-path

    config-linux: Add restriction for duplicated device path
    mrunalp committed on GitHub Jan 12, 2017
  5. defs.json: add misssing int64Pointer

    Signed-off-by: Ma Shimiao <mashimiao.fnst@cn.fujitsu.com>
    Mashimiao committed Jan 12, 2017
  6. config-linux: Add restriction for duplicated device path

    I think runtime should generate an error, if devices has
    duplicated device path.
    Because we don't know which one is really needed.
    
    Signed-off-by: Ma Shimiao <mashimiao.fnst@cn.fujitsu.com>
    Mashimiao committed Jan 5, 2017
  7. Merge pull request #649 from wking/allow-tweaking

    config-linux: Lift no-tweaking namespace restriction
    crosbymichael committed on GitHub Jan 12, 2017
Commits on Jan 11, 2017
  1. config-linux: Lift no-tweaking namespace restriction

    This restriction originally landed via 02b456e (Clarify behavior
    around namespaces paths, 2015-09-08, #158).  The hostname case landed
    via 66a0543 (config: Require a new UTS namespace for config.json's
    hostname, 2015-10-05, #214) citing the namespace restriction.  The
    restriciton extended to runtime namespaces in 01c2d55 (config-linux:
    Extend no-tweak requirement to runtime namespaces, 2016-08-24, #538).
    There was a proposal in-flight to get config-wide consistency around
    the no-tweaking concept [1].
    
    In today's meeting, the maintainer consensus was to strike the
    no-tweaking restriction [2], which is what I've done here.  I've
    removed the ROADMAP entry because this gives folks a way to adjust
    existing containers (launch a new container which joins and tweaks the
    original).
    
    The hostname entry still mentions the UTS namespace to provide a guard
    against accidental foot-gunning.  There was no no-tweaking language
    for properties related to other namespaces (e.g. 'mounts').
    Maybe the other namespaces have more obvious names.
    
    [1]: #540
    [2]: http://ircbot.wl.linuxfoundation.org/meetings/opencontainers/2017/opencontainers.2017-01-11-22.04.log.html#l-117
    
    Signed-off-by: W. Trevor King <wking@tremily.us>
    wking committed Jan 11, 2017
  2. Merge pull request #646 from q384566678/json-test

    Perfect json content
    mrunalp committed on GitHub Jan 11, 2017
  3. Merge pull request #607 from hqhq/handle_duplicated_rlimits

    Forbid duplicated rlimits with same type
    mrunalp committed on GitHub Jan 11, 2017
Commits on Jan 10, 2017
  1. Merge pull request #648 from hqhq/all_negative_value

    Allow negative value for some resource fields
    hqhq committed on GitHub Jan 10, 2017
Commits on Jan 6, 2017
  1. Perfect json content

    Signed-off-by: zhouhao <zhouhao@cn.fujitsu.com>
    q384566678 committed Jan 5, 2017
  2. Merge pull request #427 from wking/optional-hooks

    config: Explicitly list 'hooks' as optional
    mrunalp committed on GitHub Jan 6, 2017
Commits on Jan 5, 2017
  1. Allow negative value for some resource fields

    Carry #499
    
    For these values, cgroup kernal APIs accept -1 to set
    them as unlimited, as docker and runc all support
    update resources, we should not set drawbacks in spec.
    
    Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
    hqhq committed Jan 5, 2017
Commits on Jan 4, 2017
  1. config: Explicitly list 'hooks' as optional

    And make it omitempty, otherwise:
    
      $ ocitools generate --template <(echo '{}')
      $ cat config.json | jq -S .
      {
        "hooks": {},
        ...
      }
    
    To provide space for the type information and 'optional', I've
    shuffled the hook docs to follow our usual:
    
      * **`{property}`** ({type}, {when-needed}) {notes}
    
    format.  I've kept the separate event-trigger sections (e.g. "###
    Prestart") since they go into more detail on the timing, purpose, and
    exit handling for the different events (and that seemed like too much
    information to put into the nested lists).
    
    I've replaced the Go reference from 48049d2 (Clarify the semantics of
    hook elements, 2015-11-25, #255) with POSIX references (following the
    new process docs) to address pushback against referencing Go [1,2] in
    favor of POSIX links [3].  Rob Dolin had suggested
    "platform-appropriate" wording [4], but it seems like Visual Studio
    2015 supports execv [5], and providing an explicit
    "platform-appropriate" wiggle seems like it's adding useless
    complication.
    
    [1]: #427 (comment)
    [2]: http://ircbot.wl.linuxfoundation.org/meetings/opencontainers/2016/opencontainers.2016-05-18-17.01.log.html#l-46
    [3]: http://ircbot.wl.linuxfoundation.org/meetings/opencontainers/2016/opencontainers.2016-05-18-17.01.log.html#l-52
    [4]: http://ircbot.wl.linuxfoundation.org/meetings/opencontainers/2016/opencontainers.2016-05-18-17.01.log.html#l-54
    [5]: https://msdn.microsoft.com/en-us/library/886kc0as.aspx
    
    Signed-off-by: W. Trevor King <wking@tremily.us>
    wking committed May 6, 2016
  2. config: Adjust process.args to cite POSIX's execvp

    This punts the awkward-to-enforce "MUST be available at the given path
    inside of the rootfs" to the kernel, which will do a much better job
    of enforcing that constraint than runtime code or a static validator.
    
    It also punts most of the semantics to POSIX, which does a better job
    than we'll do at specifying this.  The extension is necessary because
    POSIX allows argv to be empty.  In the DESCRIPTION:
    
      The argument arg0 should point to a filename that is associated with
      the process being started by one of the exec functions.
    
    And in RATIONALE:
    
      Early proposals required that the value of argc passed to main() be
      "one or greater".  This was driven by the same requirement in drafts
      of the ISO C standard.  In fact, historical implementations have
      passed a value of zero when no arguments are supplied to the caller
      of the exec functions.  This requirement was removed from the ISO C
      standard and subsequently removed from this volume of IEEE Std
      1003.1-2001 as well.  The wording, in particular the use of the word
      should, requires a Strictly Conforming POSIX Application to pass at
      least one argument to the exec function, thus guaranteeing that argc
      be one or greater when invoked by such an application.  In fact,
      this is good practice, since many existing applications reference
      argv[0] without first checking the value of argc.
    
    But with an empty 'args' we will have no process to call (since
    process lacks an explicit 'file' analog).
    
    I chose the 2001/2004 POSIX spec for consistency with the existing
    reference (which landed in 7ac41c6, config.md: reformat into a
    standard style, 2015-06-30, which did not motivate it's use of an
    older standard).  For 2001 vs. 2004, [1] has:
    
      Abstract: The 2004 edition incorporates Technical Corrigendum Number
      1 and Technical Corrigendum 2 addressing problems discovered since
      the approval of the 2001 edition. These are mainly due to resolving
      integration issues raised by the merger of the Base documents.
    
    and the text in the linked pages uses "IEEE Std 1003.1-2001" for
    internal linking.
    
    Rob Dolin had suggested "platform-appropriate" wording [2], but it
    seems like Visual Studio 2015 supports execvp [3], and providing an
    explicit "platform-appropriate" wiggle seems like it's adding useless
    complication.
    
    [1]: http://pubs.opengroup.org/onlinepubs/009695399/mindex.html
    [2]: http://ircbot.wl.linuxfoundation.org/meetings/opencontainers/2016/opencontainers.2016-05-18-17.01.log.html#l-54
    [3]: https://msdn.microsoft.com/en-us/library/3xw6zy53.aspx
    
    Signed-off-by: W. Trevor King <wking@tremily.us>
    wking committed May 20, 2016
  3. config: Adjust process.env to immediately punt to POSIX

    The uppercase letter / digit / underscore restriction is just for
    "variables used by the utilities in the Shell and Utilities volume of
    IEEE Std 1003.1-2001".
    
    Copying over some POSIX wording and then linking to POSIX didn't seem
    like much gain.  Just point people at POSIX and let them read about
    the name=value definition, charset suggestions, etc. there.
    
    Also link specifically to chapter 8 section 1 (instead of just chapter
    8).
    
    Rob Dolin had suggested "platform-appropriate" wording [1], but it
    seems like Visual Studio 2015 supports an environment-variable array
    with the same semantics [2], and providing an explicit
    "platform-appropriate" wiggle seems like it's adding useless
    complication.
    
    [1]: http://ircbot.wl.linuxfoundation.org/meetings/opencontainers/2016/opencontainers.2016-05-18-17.01.log.html#l-54
    [2]: https://msdn.microsoft.com/en-us/library/431x4c1w.aspx
    
    Signed-off-by: W. Trevor King <wking@tremily.us>
    wking committed May 20, 2016
Commits on Dec 28, 2016
  1. config.md: add empty limit for key of annotations

    empty key does not make any senses, we should limit it.
    
    Signed-off-by: Ma Shimiao <mashimiao.fnst@cn.fujitsu.com>
    Mashimiao committed Dec 28, 2016
Commits on Dec 24, 2016
  1. Merge pull request #612 from RobDolinMS/patch-12

    [Bundle] Adds anchor tags for headings and bullets
    hqhq committed on GitHub Dec 24, 2016
Commits on Dec 23, 2016
  1. Merge pull request #643 from wking/runtime-config.md-typo

    runtime: Fix config.md -> config.json typo
    hqhq committed on GitHub Dec 23, 2016
Commits on Dec 14, 2016
  1. Merge pull request #637 from RobDolinMS/patch-17

    [Config Windows] Add anchor tags for headings
    vbatts committed on GitHub Dec 14, 2016
  2. Merge pull request #639 from RobDolinMS/patch-19

    [Principles] Add anchor tags for headings
    vbatts committed on GitHub Dec 14, 2016
  3. Merge pull request #636 from RobDolinMS/patch-16

    [Config Solaris] Add anchor tags for headings
    vbatts committed on GitHub Dec 14, 2016
  4. Merge pull request #640 from RobDolinMS/patch-20

    [Runtime Linux] Add anchor tags for headings
    vbatts committed on GitHub Dec 14, 2016
  5. Merge pull request #638 from RobDolinMS/patch-18

    [Glossary] Add anchor tags for headings
    vbatts committed on GitHub Dec 14, 2016
  6. Merge pull request #642 from vbatts/version-bump

    Version bump for v1.0.0-rc3
    vbatts committed on GitHub Dec 14, 2016
Commits on Dec 12, 2016
  1. version: master back to -dev

    Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
    vbatts committed Dec 7, 2016
  2. version: release rc3

    Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
    vbatts committed Dec 7, 2016
Commits on Dec 7, 2016
  1. ChangeLog: Document changes since v1.0.0-rc2

    Through d12da90 (Merge pull request #633 from
    WeiZhang555/syncup-hook-state, 2016-12-06).
    
    Signed-off-by: W. Trevor King <wking@tremily.us>
    wking committed Dec 7, 2016
  2. runtime: Fix config.md -> config.json typo

    From 766abd6 (runtime.md: Require 'create' to fail if config.json
    asks for the impossible, 2016-09-08, #559).
    
    Signed-off-by: W. Trevor King <wking@tremily.us>
    wking committed Dec 7, 2016
Commits on Dec 6, 2016
  1. Merge pull request #633 from WeiZhang555/syncup-hook-state

    Rename `version` to `ociVersion` according to runtime.md
    vbatts committed on GitHub Dec 6, 2016
Commits on Dec 1, 2016
  1. [Runtime Linux] Add anchor tags for headings

    Signed-off-by: Rob Dolin <robdolin@microsoft.com>
    RobDolinMS committed on GitHub Dec 1, 2016
  2. [Principles] Add anchor tags for headings

    Signed-off-by: Rob Dolin <robdolin@microsoft.com>
    RobDolinMS committed on GitHub Dec 1, 2016
  3. [Glossary] Add anchor tags for headings

    Signed-off-by: Rob Dolin <robdolin@microsoft.com>
    RobDolinMS committed on GitHub Dec 1, 2016