version: include version in produced docs #406

Merged
merged 1 commit into from May 2, 2016

Projects

None yet

3 participants

@vbatts
Member
vbatts commented Apr 27, 2016 edited

Fixes #398

This produces a markdown page as a header for the PDF and HTML pages.

Signed-off-by: Vincent Batts vbatts@hashbangbash.com

@wking
Contributor
wking commented Apr 27, 2016

On Wed, Apr 27, 2016 at 07:54:30AM -0700, Vincent Batts wrote:
“ A .tool/version-doc.go (25)”

This is depressingly large when an inline:

$ sed -n 's/."ociVersion": *"([^"])",/Specification Version: \1/p' config.md

would do the same thing (assuming we update the example 1). But
maybe relying on Go is more portable than relying on sed? On the
other hand, systems that have ‘make’ are likely to have ‘sed’.

Aside from that minor grump, 73ef76d looks good to me.

@crosbymichael
Member

LGTM

plz rebase

@vbatts vbatts version: include version in produced docs
Fixes #398

Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
174d143
@vbatts vbatts merged commit 4941dba into opencontainers:master May 2, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vbatts vbatts deleted the vbatts:version_page branch May 2, 2016
@wking wking referenced this pull request May 7, 2016
Merged

args is an array of strings #416

@Mashimiao Mashimiao added a commit to Mashimiao/specs that referenced this pull request Aug 19, 2016
@vbatts @Mashimiao vbatts + Mashimiao version: include version in produced docs (#406)
Fixes #398

Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
09e00bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment