Skip to content

[WIP] fix SetKeyLabel in old kernels with selinux enabled #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[WIP] fix SetKeyLabel in old kernels with selinux enabled #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion go-selinux/selinux_linux.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,21 @@ func SocketLabel() (string, error) {
// SetKeyLabel takes a process label and tells the kernel to assign the
// label to the next kernel keyring that gets created
func SetKeyLabel(label string) error {
return writeCon("/proc/self/attr/keycreate", label)
if label == "" && GetEnabled() {
if _, err := KeyLabel(); err == io.EOF || os.IsNotExist(err) {
// If we got io.EOF err, this means it is the first time write "" to keycreate
// And in some old kernels before Linux 2.6.18, there is no keycreate file
// So we can ignore these errors
return nil
}
}
err := writeCon("/proc/self/attr/keycreate", label)
if os.IsNotExist(err) {
// For non empty label, In some old kernels before Linux 2.6.18,
// there is no keycreate file, so we can ignore it
return nil
}
return err
}

// KeyLabel retrieves the current kernel keyring label setting
Expand Down