Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Simplify developer setup using Cometd from Git #73

Closed
vinomaster opened this Issue · 7 comments

3 participants

Dan Gisolfi Richard Backhouse Chris Cotter
Dan Gisolfi
Owner

We need to simplify our developer setup a bit. Instead of using a bash script to fetch a cometd stable release to get the JS out of it for our JS builds, we can ref a tagged version on github as a submodule and let git pull down the release.

https://groups.google.com/d/msg/cometd-dev/GQAWcAxmsQg/sByiDmU91YMJ

Richard Backhouse
Owner

The setup_js.sh script currently wraps the cometd javascript with an AMD wrapper. We would still have to do this even if we grab the code from a git submodule.

Richard Backhouse
Owner

There is a bug opened to make the cometd javascript AMD compliant

http://bugs.cometd.org/browse/COMETD-336

When this is complete we can remove the code wrappering.

Dan Gisolfi
Owner

A decision has been made to offer our patch to the CometD team using the conversation in issue http://bugs.cometd.org/browse/COMETD-336

We will remove this issue from our current milestone plan and address it once we have a decision from the CometD team.

Richard Backhouse
Owner

I have created a pull request for adding AMD support to cometd

cometd/cometd#7

Richard Backhouse
Owner

I should add that if/when these changes are available we will have to make a small adoption in "coweb/session/bayeux/cometd.js :

define([
'coweb/util/xhr',
'org/cometd',
'org/cometd/AckExtension'
], function(xhr, cometd, AckExtension) {
...

c.registerExtension('ack', new AckExtension());

org/cometd/AckExtension is now its own separate module

Chris Cotter
Owner

With #189, we have upgraded to use cometd 2.5 with AMD support, thus simplifying the maven build process for coweb-javascript. I'll see what else needs to be done to close this issue.

Chris Cotter ccotter referenced this issue from a commit
Chris Cotter ccotter Cleanup of /js and update one last version to 0.8.4-SNAPSHOT
servers/java/coweb-admin/admin-ejb/pom.xml needed a version to be
bumped.

For #73 and in anticipation of new python enhancements #203, I have
removed js/lib since the JS code now lives in
servers/java/coweb-javascript. Other outdated scripts have been removed
and I did some other general house cleaning.
3da0f0a
Chris Cotter
Owner

As far as I can tell, setup_js.sh is no longer needed (it certainly isn't being used at this time). With the new python enhancements, we can get rid of a lot of the files in /js. I believe we can close this issue.

Chris Cotter ccotter closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.