fix: amend date of certification for verifying certificate #7098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naftis
requested changes
Jun 7, 2024
packages/client/src/views/VerifyCertificate/VerifyCertificatePage.tsx
Outdated
Show resolved
Hide resolved
Zangetsu101
reviewed
Jun 14, 2024
Zangetsu101
requested changes
Jun 14, 2024
packages/client/src/views/VerifyCertificate/VerifyCertificatePage.tsx
Outdated
Show resolved
Hide resolved
|
Don't we require to create countryconfig PR for the translation change? |
Opened one for the Farajaland. Also need to create one for country config as well, right? |
|
Only needed in countryconfig actually as it will eventually get merged into farajaland |
Zangetsu101
approved these changes
Jun 20, 2024
tareq89
pushed a commit
that referenced
this pull request
Jun 20, 2024
* fix: amend date of certification for verifying certificate * Revert "fix: amend date of certification for verifying certificate" This reverts commit 785a85b. * fix: show certified date in qr code verification page * chore: add comment for last certfied date * fix: amend certificate time extraction logic * fix: update certified at message id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Farajaland PR: opencrvs/opencrvs-countryconfig#150