Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keyframe attribute of interpolated shapes #1937

Merged
merged 3 commits into from
Jul 27, 2020
Merged

Fix keyframe attribute of interpolated shapes #1937

merged 3 commits into from
Jul 27, 2020

Conversation

zhiltsov-max
Copy link
Contributor

@zhiltsov-max zhiltsov-max commented Jul 27, 2020

Motivation and context

Fixes #1934

Interpolated shapes were inserted with keyframe = True, so all exported tracks had keyframe=1 everywhere in CVAT for video and other formats.

  • Fixed keyframe attribute of interpolated shapes
  • Added tests

How has this been tested?

Unit tests

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

bsekachev
bsekachev previously approved these changes Jul 27, 2020
@coveralls
Copy link

coveralls commented Jul 27, 2020

Pull Request Test Coverage Report for Build 6592

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.004%) to 64.942%

Files with Coverage Reduction New Missed Lines %
cvat/apps/engine/media_extractors.py 3 75.22%
Totals Coverage Status
Change from base Build 6575: -0.004%
Covered Lines: 11080
Relevant Lines: 16658

💛 - Coveralls

@nmanovic nmanovic merged commit 90b5752 into develop Jul 27, 2020
@nmanovic nmanovic deleted the zm/fix-1934 branch July 27, 2020 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants