Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added notification message when browser is wrong #2070

Merged
merged 3 commits into from
Aug 24, 2020

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Aug 24, 2020

Motivation and context

Need to notify users if they are using wrong browser (CVAT supports engines Blink and Gecko, not WebKit (like in case of Safary)).

How has this been tested?

Manual testing (Chrome, Firefox, Opera, Yandex)

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

Resolve #2037

@bsekachev bsekachev added the enhancement New feature or request label Aug 24, 2020
@coveralls
Copy link

coveralls commented Aug 24, 2020

Pull Request Test Coverage Report for Build 7083

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 69.72%

Totals Coverage Status
Change from base Build 7079: 0.0%
Covered Lines: 11748
Relevant Lines: 16392

💛 - Coveralls

ActiveChooN
ActiveChooN previously approved these changes Aug 24, 2020
@bsekachev bsekachev merged commit 9e05ffc into develop Aug 24, 2020
@bsekachev bsekachev deleted the bs/browser_notification branch August 24, 2020 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a warning to non-chromium browsers
3 participants