Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace get_config_var() with get_config_vars() in setup.py. #274

Merged
merged 1 commit into from Dec 30, 2019

Conversation

@rockywhisper
Copy link
Contributor

@rockywhisper rockywhisper commented Dec 27, 2019

The get_config_var() is deprecated since Python3, and it causes a warning: warnings.warn('SO is deprecated, use EXT_SUFFIX', DeprecationWarning, 2)

If we change to get_config_vars().get("SO"), it would be compatible with both Python2 and Python3. So why not :-)

@skvark
Copy link
Member

@skvark skvark commented Dec 29, 2019

Thanks, I'll wait for the Travis builds to finish before merging (there were some issues with Travis cache so I had to restart the build).

Loading

@skvark skvark merged commit ac48881 into opencv:master Dec 30, 2019
2 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants