Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OE-26 "Revise Samples" discussion #11021

Open
vpisarev opened this issue Mar 6, 2018 · 4 comments

Comments

@vpisarev
Copy link
Contributor

commented Mar 6, 2018

the feature request about evolution proposal OE-26

@vpisarev vpisarev added the evolution label Mar 6, 2018
@vpisarev vpisarev added this to the 4.0 milestone Mar 6, 2018
@dustsigns

This comment has been minimized.

Copy link

commented Mar 26, 2018

I'd be happy to contribute some samples for the viz module. I use it a lot and find that the documentation is lacking. There are currently practically no existing samples. I think that samples for the viz module would benefit OpenCV greatly.

I already have various samples (e.g., here with code and here with code), not only using the viz module, but also many other parts of OpenCV (see full list). The samples are currently not standalone, but I can modify them, if desired. They are already under a BSD 3-Clause License.

Note: The viz module is affected by the regression documented in #10944, impacting some core functionality of many samples. #10944 would have to be fixed before adding viz samples makes sense.

@LaurentBerger

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2018

About sample
Is it possible to define standard keys for a sample (as q to quit) ?
Is it possible to run a sample without data file (only simulated data)? can we add a file browser in opencv ?
Is it possible to change opencv tree?
opencv -- modules
-- Samples --- tutorial_cpp
--- tutorial python
--- OldSample --- highgui
--- imgproc
--- etc
Insert in tutorial_sample only validated example with html page (opencv version is written)
For other examples a page with function used in sample

Source   fonction fonction fonction fonction fonction fonction   module
`3calibration.cpp Calibrate 3 cameras in a horizontal line together calibrateCamera stereoCalibrate findChessboardCorners drawChessboardCorners rectify3Collinear initUndistortRectifyMap   calib3d
`
@vpisarev

This comment has been minimized.

Copy link
Contributor Author

commented Mar 30, 2018

@dustsigns, thanks! You are very welcome to do so! We will review the samples to have and possibly express our wishes, which of them we would integrate first of all. Thanks again!

@vpisarev

This comment has been minimized.

Copy link
Contributor Author

commented Mar 30, 2018

@LaurentBerger, thank you, that's many useful suggestions!

  • on the standard keys - agree, but there will likely be a few options to exit, for example (q, ESC, maybe also system-defined shortcuts like Alt+F4 or Cmd+Q)
  • simulated data - not always possible; since the samples come with the complete OpenCV distribution, we'd better modify samples so that they can locate standard data files (e.g. lena.jpg) automatically w/o copying the data manually.
  • file browser - this is rather about highgui extension. Honestly, I do not see much sense in it, because manual file selection is very very boring. Using command-line parameters, config files etc. is much more convenient approach when you need to do it repeatedly
  • we will likely split some of the samples by the corresponding modules, but some basic samples will likely be retained in the common samples directory; have not decided yet. We are not going to keep the old samples; there is point to preserve some old API, but not the old samples.
  • web page with samples description - it definitely makes sense. We would appreciate if someone creates such a page; but first we need to revise the list of our samples and probably shrink it, as there are too many samples right now, in my opinion
@alalek alalek modified the milestones: 4.0-beta, 4.0 Sep 18, 2018
@alalek alalek modified the milestones: 4.0.0-beta, 4.0.0 Oct 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.